[18.0][MIG] sms_alternative_provider - use of SmsApiBase#360
Open
anthonissen-a wants to merge 3 commits intoOCA:18.0from
Open
[18.0][MIG] sms_alternative_provider - use of SmsApiBase#360anthonissen-a wants to merge 3 commits intoOCA:18.0from
anthonissen-a wants to merge 3 commits intoOCA:18.0from
Conversation
anthonissen-a
changed the title
anthonissen-a
force-pushed
the
18.0-sms_alternative_provider-aan
branch
2 times, most recently
from
47ae213 to
0cd5299
Compare
Contributor
|
Thanks for this PR |
Author
anthonissen-a
force-pushed
the
18.0-sms_alternative_provider-aan
branch
from
0cd5299 to
d297cdf
Compare
Member
|
@anthonissen-a is taking over his teammate @bjouini-acsone work made in #355 I'll close #355 |
Member
|
I don't see the fixups in the history of the module. From what I understand the history of this PR is based on the work in progress of #327 before it was squashed and merged. Could you rebase this PR on top of a cherry pick of this commit feb05cf |
Member
|
/ocabot migration sms_alternative_provider |
anthonissen-a
force-pushed
the
18.0-sms_alternative_provider-aan
branch
from
d297cdf to
847cf5e
Compare
anthonissen-a
force-pushed
the
18.0-sms_alternative_provider-aan
branch
from
847cf5e to
e4d8f33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the new abstract class SmsApiBase from Odoo as a base to implement for any alternative provider.
The prefix isn’t implemented yet. Wouldn’t it be better to handle it in a separate module?