[16.0][FIX] _primary_email #784
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a critical issue with email loop detection in the helpdesk.ticket model by adding the missing _primary_email attribute, which prevents spam and duplicate ticket creation through email aliases.
Problem
The helpdesk.ticket model was missing the _primary_email attribute, causing the following issues:
Root Cause
The _detect_loop_sender_domain method in mail.thread relies on the _primary_email attribute to:
When _primary_email is not defined, the method returns None, effectively disabling loop detection for that model.