Skip to content

Conversation

@HekkiMelody
Copy link

@HekkiMelody HekkiMelody commented Sep 15, 2025

The module makes session garbage collection deterministic To use the module, it needs to be added to the
server_wide_modules conf options

Another option should also be added
to set gc for all sessions older than 3 days

;3 days = 60*60*24*3 seconds
session_expiry_delay = 259200

(it's not quite possible to test this in runboat unfortunately)

Closes task 909851

Depends #63

@OCA-git-bot
Copy link
Collaborator

Hi @petrus-v,
some modules you are maintaining are being modified, check this out!

@HekkiMelody
Copy link
Author

HekkiMelody commented Sep 15, 2025

It looks like building the docker image fails because it cannot install postgres

https://github.com/OCA/oca-custom/actions/runs/17727340361/job/50370780890?pr=64#step:5:330

I don't think focal is included among the official ubuntu repositories by postgres any longer.

@HekkiMelody HekkiMelody force-pushed the 14.0-base-deterministic-session-gc branch from be7be72 to 8ebbb7d Compare September 15, 2025 09:04
@HekkiMelody HekkiMelody marked this pull request as draft September 15, 2025 09:06
@HekkiMelody
Copy link
Author

I've rebased on top of #63 which is not yet merged

@HekkiMelody HekkiMelody force-pushed the 14.0-base-deterministic-session-gc branch 2 times, most recently from 4c5392d to cd90018 Compare September 15, 2025 13:06
@thomaspaulb
Copy link

@aleuffre So I applied this on test.odoo-community.org, but when running the scheduled action, I run into:

ValueError: <class 'AttributeError'>: "module 'odoo.http' has no attribute 'deterministic_session_gc'" while evaluating
'model.gc_sessions()'

@thomaspaulb
Copy link

Ah wait, I need to add the module in server_wide_modules also.

The module makes session garbage collection deterministic
To use the module, it needs to be added to the
server_wide_modules conf options

Another option should also be added
to set gc for all sessions older than 3 days

;3 days = 60*60*24*3 seconds
session_expiry_delay = 259200
@HekkiMelody HekkiMelody force-pushed the 14.0-base-deterministic-session-gc branch from cd90018 to fd1b4bb Compare September 17, 2025 12:55
@HekkiMelody HekkiMelody marked this pull request as ready for review September 17, 2025 12:55
@HekkiMelody HekkiMelody marked this pull request as draft September 17, 2025 12:55
@petrus-v
Copy link

petrus-v commented Oct 9, 2025

Could you close this PR your work has been integrated in #65

@thomaspaulb thomaspaulb closed this Oct 9, 2025
@HekkiMelody HekkiMelody deleted the 14.0-base-deterministic-session-gc branch October 9, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants