-
-
Notifications
You must be signed in to change notification settings - Fork 265
[18.0][MIG] purchase_stock_operating_unit: Migration to 18. #755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 18.0
Are you sure you want to change the base?
[18.0][MIG] purchase_stock_operating_unit: Migration to 18. #755
Conversation
c2cf774 to
b4866a1
Compare
kanisorn-kate
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
4c4cbe6 to
39e1334
Compare
| class PurchaseOrder(models.Model): | ||
| _inherit = "purchase.order" | ||
|
|
||
| picking_type_id = fields.Many2one( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional Test 👍
But I'm not sure. Should we use onchange instead compute with picking_type_id and operating_unit_id?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think onchange makes more sense. Maybe a constraint if there is inconsistency with the operating unit.
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
39e1334 to
5585f0d
Compare
No description provided.