[18.0][MIG] pos_edit_order_line: Migration to 18.0 #1293

BhaveshHeliconia · 2025-02-10T09:14:34Z

No description provided.

github-actions · 2025-08-03T12:52:21Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

Currently translated at 100.0% (15 of 15 strings) Translation: pos-14.0/pos-14.0-pos_edit_order_line Translate-URL: https://translation.odoo-community.org/projects/pos-14-0/pos-14-0-pos_edit_order_line/it/

Currently translated at 100.0% (13 of 13 strings) Translation: pos-16.0/pos-16.0-pos_edit_order_line Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_edit_order_line/es/

Currently translated at 100.0% (13 of 13 strings) Translation: pos-16.0/pos-16.0-pos_edit_order_line Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_edit_order_line/it/

Currently translated at 100.0% (15 of 15 strings) Translation: pos-16.0/pos-16.0-pos_edit_order_line Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_edit_order_line/it/

Currently translated at 100.0% (15 of 15 strings) Translation: pos-16.0/pos-16.0-pos_edit_order_line Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_edit_order_line/es/

FrancoMaxime

LGTM: code & functional review.

A minor comment

FrancoMaxime · 2025-09-16T10:52:23Z

pos_edit_order_line/static/src/xml/EditOrderPopup.xml

+        <!--        <div role="dialog" class="modal-dialog edit-order-popup">-->
+        <!--            <div class="popup popup-text">-->
+        <!--                <header class="title">-->
+        <!--                    <t t-esc="props.title" />-->
+        <!--                </header>-->
+        <!--                <footer class="footer">-->
+        <!--                    <div class="button confirm" t-on-click="confirm">-->
+        <!--                        <t t-esc="props.confirmText" />-->
+        <!--                    </div>-->
+        <!--                    <div class="button cancel" t-on-click="cancel">-->
+        <!--                        <t t-esc="props.cancelText" />-->
+        <!--                    </div>-->
+        <!--                </footer>-->
+        <!--            </div>-->
+        <!--        </div>-->


If it's not needed, can you remove it?

github-actions · 2026-01-18T12:50:09Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

BhaveshHeliconia · 2026-01-20T10:55:24Z

Hey @OCA/pos-maintainers would be great if someone could have a look at this module.

ivantodorovich

Thanks!

Small comments, pre-approving

ivantodorovich · 2026-01-20T11:29:19Z

pos_edit_order_line/models/ir_module_module.py

+
+    @api.model
+    def _load_pos_data_fields(self, config_id=None):
+        return super()._load_pos_data_fields()


This override is not doing anything, you can remove it

This override is required for method signature compatibility: POS may call _load_pos_data_fields(config_id), but core doesn’t accept that argument. The override keeps behavior identical while preventing a TypeError in POS tests.

OCB Error :-
During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "/opt/odoo/odoo/tests/common.py", line 1499, in _websocket_request
return f.result(timeout=timeout)
File "/usr/lib/python3.10/concurrent/futures/_base.py", line 460, in result
raise TimeoutError()
concurrent.futures._base.TimeoutError

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
File "/opt/odoo/odoo/tests/common.py", line 1221, in stop
self._websocket_request('Runtime.evaluate', params={'expression': """
File "/opt/odoo/odoo/tests/common.py", line 1501, in _websocket_request
raise TimeoutError(f'{method}({params or ""})')
TimeoutError: Runtime.evaluate({'expression': "\n ('serviceWorker' in navigator) &&\n navigator.serviceWorker.getRegistrations().then(\n registrations => Promise.all(registrations.map(r => r.unregister()))\n )\n ", 'awaitPromise': True})
2026-01-21 11:51:08,519 305 ERROR odoo odoo.addons.pos_display_total_quantity.tests.test_frontend: FAIL: TestDisplayTotalQty.test_display_total_qty
Traceback (most recent call last):
File "/__w/pos/pos/pos_display_total_quantity/tests/test_frontend.py", line 13, in test_display_total_qty
self.start_tour(
File "/opt/odoo/addons/account/tests/common.py", line 1496, in start_tour
super().start_tour(url_path, tour_name, step_delay, **kwargs)
File "/opt/odoo/odoo/tests/common.py", line 2305, in start_tour
return self.browser_js(url_path=url_path, code=code, ready=ready, timeout=timeout, success_signal="tour succeeded", **kwargs)
File "/opt/odoo/odoo/tests/common.py", line 2279, in browser_js
self.fail('%s\n\n%s' % (message, error))
AssertionError: The test code "odoo.startTour('DisplayTotalQty', {"stepDelay": 0, "keepWatchBrowser": false, "debug": false, "startUrl": "/pos/ui?config_id=7", "delayToCheckUndeterminisms": 0})" failed

I'm sorry, I don't get it.

I still see no reason for this override in this module.

Can you elaborate?

ivantodorovich · 2026-01-20T11:32:22Z

pos_edit_order_line/static/src/js/EditOrderButton.esm.js

+        if (
+            this.pos.get_order().get_orderlines() &&
+            this.pos.get_order().get_orderlines().length > 0
+        ) {
+            var order_lines = this.pos.get_order().get_orderlines();


Same thing, but with fewer characters and calls to get_order() and get_orderlines()

Suggested change

if (

this.pos.get_order().get_orderlines() &&

this.pos.get_order().get_orderlines().length > 0

) {

var order_lines = this.pos.get_order().get_orderlines();

const order_lines = this.pos.get_order().get_orderlines();

if (order_lines?.length) {

ivantodorovich · 2026-01-20T11:34:02Z

pos_edit_order_line/static/src/js/EditOrderPopup.esm.js

+        var self = this;
+        self.changes[id] = changes;


Suggested change

var self = this;

self.changes[id] = changes;

this.changes[id] = changes;

BhaveshHeliconia mentioned this pull request Feb 10, 2025

Migration to version 18.0 #1251

Open

17 tasks

BhaveshHeliconia force-pushed the 18.0-mig-pos_edit_order_line branch from 82ad6b7 to 489a355 Compare February 10, 2025 11:56

BhaveshHeliconia force-pushed the 18.0-mig-pos_edit_order_line branch from 489a355 to c681fbe Compare April 2, 2025 12:41

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 3, 2025

diga and others added 12 commits August 6, 2025 16:22

[ADD] add new module: pos_edit_order_line

a7ab951

Added translation using Weblate (Italian)

bef316d

Translated using Weblate (Italian)

2d91e78

Currently translated at 100.0% (15 of 15 strings) Translation: pos-14.0/pos-14.0-pos_edit_order_line Translate-URL: https://translation.odoo-community.org/projects/pos-14-0/pos-14-0-pos_edit_order_line/it/

[FIX][DOC] pos_edit_order_line : correct reference to description image

a71efdf

[MIG] pos_edit_order_line: Migration to 16.0

8f8a4c0

Added translation using Weblate (Spanish)

5fad600

Translated using Weblate (Spanish)

534746a

Currently translated at 100.0% (13 of 13 strings) Translation: pos-16.0/pos-16.0-pos_edit_order_line Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_edit_order_line/es/

Translated using Weblate (Italian)

e4635e8

Currently translated at 100.0% (13 of 13 strings) Translation: pos-16.0/pos-16.0-pos_edit_order_line Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_edit_order_line/it/

[FIX] Footer buttons must be translated

edae0fa

Translated using Weblate (Italian)

685fe1e

Currently translated at 100.0% (15 of 15 strings) Translation: pos-16.0/pos-16.0-pos_edit_order_line Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_edit_order_line/it/

Translated using Weblate (Spanish)

5d42a2f

Currently translated at 100.0% (15 of 15 strings) Translation: pos-16.0/pos-16.0-pos_edit_order_line Translate-URL: https://translation.odoo-community.org/projects/pos-16-0/pos-16-0-pos_edit_order_line/es/

[IMP] pos_edit_order_line: pre-commit auto fixes

f908258

BhaveshHeliconia force-pushed the 18.0-mig-pos_edit_order_line branch from c681fbe to 0bef60a Compare August 6, 2025 10:52

github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Aug 10, 2025

FrancoMaxime reviewed Sep 16, 2025

View reviewed changes

BhaveshHeliconia force-pushed the 18.0-mig-pos_edit_order_line branch 2 times, most recently from d9dfd6e to 903a0fa Compare September 16, 2025 11:48

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 18, 2026

BhaveshHeliconia force-pushed the 18.0-mig-pos_edit_order_line branch 3 times, most recently from 8cd9b87 to 47971ea Compare January 20, 2026 10:09

ivantodorovich approved these changes Jan 20, 2026

View reviewed changes

BhaveshHeliconia force-pushed the 18.0-mig-pos_edit_order_line branch from 47971ea to 86a54d4 Compare January 21, 2026 11:33

BhaveshHeliconia force-pushed the 18.0-mig-pos_edit_order_line branch from 86a54d4 to 4411a8e Compare January 21, 2026 11:39

[MIG] pos_edit_order_line: Migration to 18.0

e476768

BhaveshHeliconia force-pushed the 18.0-mig-pos_edit_order_line branch from 4411a8e to e476768 Compare January 21, 2026 12:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[18.0][MIG] pos_edit_order_line: Migration to 18.0 #1293

[18.0][MIG] pos_edit_order_line: Migration to 18.0 #1293

BhaveshHeliconia commented Feb 10, 2025

Uh oh!

github-actions bot commented Aug 3, 2025

Uh oh!

FrancoMaxime left a comment

Uh oh!

FrancoMaxime Sep 16, 2025

Uh oh!

github-actions bot commented Jan 18, 2026

Uh oh!

BhaveshHeliconia commented Jan 20, 2026

Uh oh!

ivantodorovich left a comment

Uh oh!

ivantodorovich Jan 20, 2026

Uh oh!

BhaveshHeliconia Jan 21, 2026 •

edited

Loading

Uh oh!

ivantodorovich Jan 21, 2026

Uh oh!

ivantodorovich Jan 20, 2026

Uh oh!

ivantodorovich Jan 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

	var self = this;
	self.changes[id] = changes;
	this.changes[id] = changes;

Uh oh!

[18.0][MIG] pos_edit_order_line: Migration to 18.0 #1293

Are you sure you want to change the base?

[18.0][MIG] pos_edit_order_line: Migration to 18.0 #1293

Conversation

BhaveshHeliconia commented Feb 10, 2025

Uh oh!

github-actions bot commented Aug 3, 2025

Uh oh!

FrancoMaxime left a comment

Choose a reason for hiding this comment

Uh oh!

FrancoMaxime Sep 16, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Jan 18, 2026

Uh oh!

BhaveshHeliconia commented Jan 20, 2026

Uh oh!

ivantodorovich left a comment

Choose a reason for hiding this comment

Uh oh!

ivantodorovich Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

BhaveshHeliconia Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ivantodorovich Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

ivantodorovich Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

ivantodorovich Jan 20, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

BhaveshHeliconia Jan 21, 2026 •

edited

Loading