-
-
Notifications
You must be signed in to change notification settings - Fork 788
[18.0][ADD] product_sale_team: add module #2139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 18.0
Are you sure you want to change the base?
Conversation
1c428c0 to
649b34a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an MD file, it must use markdown format.
| @tagged("post_install", "-at_install") | ||
| class TestProductSalesTeam(TransactionCase): | ||
| def test_set_sales_team_on_product_template(self): | ||
| CrmTeam = self.env["crm.team"].create({"name": "Dedicated Team"}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the goal of this test? Are we modifying the create() function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right that using create() here is misleading, as it mostly
exercises the core ORM rather than the addon itself
I’ll simplify the test to focus on what this technical module actually
provides: the sales_team_id field on product.template with the
expected Many2one to crm.team
90d87a8 to
e4713fa
Compare
da4e057 to
c6dec94
Compare
ivs-cetmix
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review LGTM
Aldeigja
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional LGTM
product_sale_team/readme/USAGE.md
Outdated
| @@ -0,0 +1,2 @@ | |||
| - Open the product | |||
| - Select a sales team in the corresponding field located in the "General Settings" tab | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| - Select a sales team in the corresponding field located in the "General Settings" tab | |
| - Select a sales team in the corresponding field located in the "General Information" tab |
- Add sales_team_id Many2one field on product.template to store the Sales Team for a product. - Extend the product template form view to display the Sales Team field on the General Information tab. - Add basic documentation (CONTEXT, DESCRIPTION, USAGE) and a test. Task: 5084
c6dec94 to
c4cb411
Compare
|
This PR has the |
|
Hey @OCA/product-maintainers would appreciate your review of this one-field module 😄 |
Task: 5084