Skip to content

[IMP] port https://github.com/OCA/product-pack/pull/159 to v17 #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
damdam-s wants to merge 1 commit into
base: 17.0
Choose a base branch
from
Open

[IMP] port https://github.com/OCA/product-pack/pull/159 to v17 #209

damdam-s wants to merge 1 commit into from

Conversation

@damdam-s
Copy link
Member

@damdam-s damdam-s commented May 12, 2025

port #159 to v17

@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented May 12, 2025

Hi @victoralmau,
some modules you are maintaining are being modified, check this out!

@damdam-s damdam-s marked this pull request as draft May 12, 2025 08:33
@damdam-s damdam-s force-pushed the 17.0-imp-sale_product_pack branch from 17520f9 to 2ba469d Compare May 12, 2025 08:37
@damdam-s
Copy link
Member Author

damdam-s commented May 12, 2025

coverage bug?
small doubt about the test not being tested 😄 https://app.codecov.io/gh/OCA/product-pack/pull/209?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=checks&utm_campaign=pr+comments&utm_term=OCA#21e22f9c6e584ea8195ca2b02312e2af-R477

@damdam-s
Copy link
Member Author

damdam-s commented May 12, 2025

@petrus-v a forward port of #159

@damdam-s damdam-s marked this pull request as ready for review May 12, 2025 09:10
@damdam-s damdam-s mentioned this pull request May 12, 2025
Closed
alexandregaldeano
alexandregaldeano approved these changes May 15, 2025
View reviewed changes
Copy link

@alexandregaldeano alexandregaldeano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

victoralmau
victoralmau suggested changes May 15, 2025
View reviewed changes
Copy link
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes appear to be consistent.

sale_product_pack/__manifest__.py
{
"name": "Sale Product Pack",
"version": "17.0.2.0.1",
"version": "17.0.2.0.2",
Copy link
Member

@victoralmau victoralmau May 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"version": "17.0.2.0.2",
"version": "17.0.2.0.2",

This change is not necessary.

Copy link
Member Author

@damdam-s damdam-s May 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hum, i'm changing some code so I bump the version.

maybe as a refactor it's not a bugfix and you want to change it to 17.0.2.1.0 ?

Copy link
Member

@victoralmau victoralmau May 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the bot is merged it will make this change automatically.
You only need to change the version on migrations and/or if migration scripts are needed.

Copy link
Member Author

@damdam-s damdam-s May 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah ok nice. fixing this

Copy link
Contributor

@rousseldenis rousseldenis Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@damdam-s

@github-actions
Copy link

github-actions bot commented Sep 14, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 14, 2025
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rousseldenis rousseldenis rousseldenis left review comments

+2 more reviewers

@victoralmau victoralmau victoralmau requested changes

@alexandregaldeano alexandregaldeano alexandregaldeano approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@damdam-s @OCA-git-bot @victoralmau @alexandregaldeano @rousseldenis