[19.0][MIG] purchase_product_pack: Migration to 19.0 #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently translated at 100.0% (21 of 21 strings) Translation: product-pack-16.0/product-pack-16.0-purchase_product_pack Translate-URL: https://translation.odoo-community.org/projects/product-pack-16-0/product-pack-16-0-purchase_product_pack/it/
Currently translated at 100.0% (21 of 21 strings) Translation: product-pack-16.0/product-pack-16.0-purchase_product_pack Translate-URL: https://translation.odoo-community.org/projects/product-pack-16-0/product-pack-16-0-purchase_product_pack/pt/
Currently translated at 100.0% (21 of 21 strings) Translation: product-pack-16.0/product-pack-16.0-purchase_product_pack Translate-URL: https://translation.odoo-community.org/projects/product-pack-16-0/product-pack-16-0-purchase_product_pack/it/
…mplification Demo data can make tests to fail in integration environments or locally modified ones, so let's remove them and use data created on the test itself. We also improve the containerization of the elements of the tests. In the same movement, we have simplified the code of the test for doing the same with less lines and in a clearer way.
yankinmax
commented
Dec 8, 2025
| "product_qty": quantity, | ||
| } | ||
| pol = line.new(line_vals) | ||
| pol.onchange_product_id_warning() |
Author
There was a problem hiding this comment.
purchase_line_warn_msg is now a computed see _compute_purchase_line_warn_msg
yankinmax
force-pushed
the
19.0-mig-purchase_product_pack
branch
3 times, most recently
from
7908518 to
0ddbeb1
Compare
yankinmax
commented
Dec 8, 2025
Comment on lines
64
to
68
| existing_subline = first( | ||
| self.pack_child_line_ids.filtered( | ||
| lambda child, subline=subline: child.product_id | ||
| == subline.product_id | ||
| ) |
Author
There was a problem hiding this comment.
fields.first is deprecated since 19.0
There was a problem hiding this comment.
A simple (and better) replacement for fields.first is simply:
records.filtered(...)[:1]just a one-liner
no need to do next/iter etc..
ivantodorovich
suggested changes
Dec 22, 2025
| self.env["purchase.order.line"] | ||
| .search( | ||
| [("id", "child_of", to_delete_ids), ("id", "not in", to_delete_ids)] | ||
| Domain("id", "child_of", to_delete_ids), ("id", "not in", to_delete_ids) |
There was a problem hiding this comment.
This is not correct. You're building a tuple here instead of a properly initialized domain
Given this is not caught by the current unit tests, can you also add one for this? (or extend an existing one)
Comment on lines
64
to
68
| existing_subline = first( | ||
| self.pack_child_line_ids.filtered( | ||
| lambda child, subline=subline: child.product_id | ||
| == subline.product_id | ||
| ) |
There was a problem hiding this comment.
A simple (and better) replacement for fields.first is simply:
records.filtered(...)[:1]just a one-liner
no need to do next/iter etc..
vvrossem
reviewed
Jan 9, 2026
| self.env["purchase.order.line"] | ||
| .search( | ||
| [("id", "child_of", to_delete_ids), ("id", "not in", to_delete_ids)] | ||
| Domain("id", "child_of", to_delete_ids), ("id", "not in", to_delete_ids) |
There was a problem hiding this comment.
Nice catch Ivan 🐐. If I'm not wrong, this is one possible implementation:
Suggested change
| Domain("id", "child_of", to_delete_ids), ("id", "not in", to_delete_ids) | |
| Domain("id", "child_of", to_delete_ids) & Domain("id", "not in", to_delete_ids) |
Alternatively:
Suggested change
| Domain("id", "child_of", to_delete_ids), ("id", "not in", to_delete_ids) | |
| Domain.AND(Domain("id", "child_of", to_delete_ids), Domain("id", "not in", to_delete_ids)) |
yankinmax
force-pushed
the
19.0-mig-purchase_product_pack
branch
from
0ddbeb1 to
07d2f6b
Compare
ivantodorovich
approved these changes
Jan 19, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.