[16.0][ADD] repair_preparation #119
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbejaoui
force-pushed
the
16.0-repair_preparation-sbj
branch
2 times, most recently
from
d39f316 to
495a3ee
Compare
sbejaoui
changed the title
sbejaoui
force-pushed
the
16.0-repair_preparation-sbj
branch
from
495a3ee to
6e69cb0
Compare
sbejaoui
force-pushed
the
16.0-repair_preparation-sbj
branch
from
6e69cb0 to
1de4451
Compare
sbejaoui
force-pushed
the
16.0-repair_preparation-sbj
branch
from
1de4451 to
e822aa4
Compare
update repair line location and lot after preparation is done
sbejaoui
force-pushed
the
16.0-repair_preparation-sbj
branch
from
5ff413b to
bb3f1d4
Compare
…repair_preparation enabled
| "because some linked moves are already done.\n" | ||
| "Repair: %(repair)s\nLines: %(lines)s" | ||
| ) | ||
| % { |
There was a problem hiding this comment.
Please use translation function arguments instead.
| if not self.preparation_group_id: | ||
| self.preparation_group_id = self.env["procurement.group"].create( | ||
| { | ||
| "name": _("Preparation for") + self.name, |
There was a problem hiding this comment.
Suggested change
| "name": _("Preparation for") + self.name, | |
| "name": _("Preparation for ") + self.name, |
| return operations.filtered( | ||
| lambda line: line.type == "add" | ||
| and line.product_id | ||
| and line.product_uom_qty > 0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The repair module consumes spare parts at the end of the repair without considering the qunatity reservation. the more natural flow is to have a staging step to bring and reserve parts before the repair begins, improving planning and reducing delays at the workbench.
This addon introduces a Preparation flow:
On Confirm (validate) of the repair, a procurement is run procurement for all eligible Add lines
When a repair line is created/edited while the repair is Under Repair:
Finishing a repair is blocked if:
cc/ @lmignon , @rousseldenis