-
-
Notifications
You must be signed in to change notification settings - Fork 492
[18.0][IMP] auth_jwt: allow more authorization options over aud #753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 18.0
Are you sure you want to change the base?
Conversation
538beb2 to
5da46e0
Compare
|
@sbidoul working aws cognito as a token provider, there are no aud. but we do have scopes and user groups. would it be useful to replace the aud with these new tests to validate a server to server account has proper scope or a user has a group? the tests are pretty sloppy ( any intersection of the sets) can refine if useful. another option might be a simple disable but really do need the scope test in our case. server-auth/auth_oidc/models/res_users.py Line 72 in 035093d
|
7342133 to
5da46e0
Compare
|
I'm ok to make Then adding validation on additional claim sounds ok too. I would not override the meaning of the audience field, though. How about an |
fabb83e to
f5e43c3
Compare
|
optional aud only |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
cbb55d1 to
8853d13
Compare
1ff8db7 to
0827f1f
Compare
| "summary": """ | ||
| JWT bearer token authentication.""", | ||
| "version": "18.0.1.0.0", | ||
| "version": "18.0.1.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Version should not be modified. It will be automatically bumped at merge.
lmignon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the proposal @dnplkndll
Can you improve the documentation to explain your new options. I personally find it difficult to understand the proposed changes and the problem they are trying to solve. I am therefore unable to give an informed opinion on what is being proposed.
@kobros-tech can you add some tests?
probably want to require one of the possible types too. so maybe a type selection [aud,scope,group] then the aud_text to use to parse the match value?
need to rebase after: #752 merges