[FIX] base_remote: Allow RPC authentication without HTTP context #3459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When authenticating via XML-RPC or JSON-RPC, there is no HTTP request context available. The remote property gracefully handles this by returning an empty recordset, but the ensure_one() check was still enforced, causing authentication to fail. This change skips the singleton check when remote is empty (no HTTP context), while maintaining device tracking for web browser connections. Fixes OCA#3458
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3458
This PR fixes a bug where XML-RPC and JSON-RPC authentication fails with
ValueError: Expected singleton: res.remote().Root Cause
When authenticating via RPC (non-HTTP requests), there is no HTTP request context available. The
remoteproperty inmodels/base.pygracefully handles this by returning an empty recordset. However,_auth_check_remoteinmodels/res_users.pyunconditionally callsensure_one()on this recordset, causing authentication to fail.Changes
base_remote/models/res_users.pyensure_one()whenremoteis empty (no HTTP context)Testing
Tested with OdooRPC Python library:
Impact