[FIX] if nocreate=1 then also see that as true

[thomaspaulb]

Some people in their custom modules have used 'no_create=1' instead of True to disable create or edit, which works in standard Odoo. But when web_m2x_options is installed, it will stop working, which is IMO undesired/unintended behavior.

[hbrunn]

why do we need the switch between types in the first place? I believe in some earlier versions we wanted to be nice for input, and then started that. But that can't be asked for a contribution to change, so I applaud fixing the symptom, this will be fine here. Thanks!

[NL66278]

👍 LGTM

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[gjotten]

@hbrunn

[hbrunn]

/ocabot merge patch

[OCA-git-bot]

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 10.0-ocabot-merge-pr-1514-by-hbrunn-bump-patch, awaiting test results.

[OCA-git-bot]

@hbrunn your merge command was aborted due to failed check(s), which you can inspect on this commit of 10.0-ocabot-merge-pr-1514-by-hbrunn-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

[dreispt]

/ocabot merge patch

[OCA-git-bot]

What a great day to merge this nice PR. Let's do it!
Prepared branch 10.0-ocabot-merge-pr-1514-by-dreispt-bump-patch, awaiting test results.

[OCA-git-bot]

@dreispt your merge command was aborted due to failed check(s), which you can inspect on this commit of 10.0-ocabot-merge-pr-1514-by-dreispt-bump-patch.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

[etobella]

@thomaspaulb Can you check the issues with travis?

[simahawk]

/ocabot rebase

[OCA-git-bot]

@simahawk The rebase process failed, because command git push --force sunflowerit tmp-pr-1514:10.0-web_m2x_options_1isalsotrue failed with output:

remote: Permission to sunflowerit/web.git denied to OCA-git-bot.
fatal: unable to access 'https://github.com/sunflowerit/web/': The requested URL returned error: 403

[thomaspaulb]

@simahawk Rebased

[thomaspaulb]

Okay I don't really know what to do here :/

[simahawk]

It's failing in the same way on 10.0.

@sbidoul do we still expect builds for 10.0 to work?

[sbidoul]

do we still expect builds for 10.0 to work?

@simahawk dunno. This is Travis & MQT, it's been ages since I looked into that. So I guess the answer is no.

[thomaspaulb]

I've tried to use guide to change this to Github actions, but I'm running into too many issues to fix. Leaving this up to @OCA/web-maintainers to decide whether to manually force-merge this, skipping CI, or close.

[NL66278]

@thomaspaulb You can switch to github actions if you remove the pre-commit job from it. GitHub no longer supports python2. pre-commit can still be used locally to check before pushing to github.

[dreispt]

I'm doing a manual merge.