[18.0][FIX] web_widget_x2many_2d_matrix: refresh totals on cell edit

[RicardCForgeFlow]

Totals were only recomputed on initial render or after saving because the renderer cached matrix/rows/columns and only rebuilt them on props updates.

2026-01-15.11-46-33.mp4

Compute matrix data from reactive list.records on each render so row/column/grand totals update immediately when a cell value changes.

2026-01-15.11-44-07.mp4

[OCA-git-bot]

Hi @JasminSForgeFlow, @DavidJForgeFlow, @hbrunn,
some modules you are maintaining are being modified, check this out!

[JasminSForgeFlow]

Code Review 👍

[hbrunn]

don't do this. The widget as is is already pretty expensive computationally, and this PR makes it much worse.

Please replace all of this with

        onWillRender(() => {
            this.columns = this._getColumns();
            this.rows = this._getRows();
            this.matrix = this._getMatrix();
        });

in setup() instead of onWillUpdateProps, this should get the caching right and won't add several times o(n^2) complexity.

Also consider expanding the test to edit a field several times and check if the totals are updated correctly

[RicardCForgeFlow]

don't do this. The widget as is is already pretty expensive computationally, and this PR makes it much worse.

Please replace all of this with

        onWillRender(() => {
            this.columns = this._getColumns();
            this.rows = this._getRows();
            this.matrix = this._getMatrix();
        });

in setup() instead of onWillUpdateProps, this should get the caching right and won't add several times o(n^2) complexity.

Also consider expanding the test to edit a field several times and check if the totals are updated correctly

Okay!

[RicardCForgeFlow]

don't do this. The widget as is is already pretty expensive computationally, and this PR makes it much worse.

Please replace all of this with

        onWillRender(() => {
            this.columns = this._getColumns();
            this.rows = this._getRows();
            this.matrix = this._getMatrix();
        });

in setup() instead of onWillUpdateProps, this should get the caching right and won't add several times o(n^2) complexity.

Also consider expanding the test to edit a field several times and check if the totals are updated correctly

Hi @hbrunn I changed the onWillUpdateProps for your code. Also added a test with the goal of replicating the problem. Please tell me if you see everything correct. Thank you very much!