Conversation
In the schema.yml native is declared as default deploy_type which was not implemented in the python-code yet
kba
approved these changes
Sep 16, 2025
Member
kba
left a comment
kba
left a comment
There was a problem hiding this comment.
LGTM, very thorough. I am confused by the one change to the test and we should really consider dropping bashlib outright. Otherwise good to go IMHO.
bertsky
reviewed
Sep 23, 2025
Collaborator
bertsky
left a comment
bertsky
left a comment
There was a problem hiding this comment.
LGTM – just an issue with ocrd-all-tool.json...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As already stated in spec-PR, I believe that the Processor Server is unnecessary, since we already have the Processing Worker. Here are the changes to OCR-D core corresponding to the change in spec.