ocrd.processor.base: add property zip_input_files#635
Merged
kba merged 10 commits intoOCR-D:masterfrom Nov 3, 2020
Merged
Conversation
kba
reviewed
Oct 26, 2020
kba
approved these changes
Oct 26, 2020
Member
kba
left a comment
kba
left a comment
There was a problem hiding this comment.
Nice, thanks. I'll test it some more and merge.
kba
reviewed
Oct 26, 2020
Codecov Report
@@ Coverage Diff @@
## master #635 +/- ##
==========================================
- Coverage 84.45% 84.03% -0.42%
==========================================
Files 52 52
Lines 2997 3075 +78
Branches 585 627 +42
==========================================
+ Hits 2531 2584 +53
- Misses 348 363 +15
- Partials 118 128 +10
Continue to review full report at Codecov.
|
kba
force-pushed
the
processor.zip_input_files
branch
from
fa31678 to
5f6b5af
Compare
kba
reviewed
Oct 26, 2020
…handling…
- allow different kinds of error handling
for the multi-match case (single page,
multiple files): `on_error`
- `skip`: None
- `first`: first match
- `last`: last match
- `abort`: raise an exception
- if `mimetype` is inactive, support default OCR-D
PAGE-image fallback semantics;
- if no PAGE but multiple other files,
then delegate to general error handling above
- if multiple PAGE files, then raise an exception
(raise an exception if no input fileGrp was set)
This was referenced Nov 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AFAICS this would already be useful for:
Most of these recently broke with the
ocrd_mets.find_filesgenerator change.