auto-invalidate derived images when changing coords#639
Merged
kba merged 3 commits intoOCR-D:masterfrom Nov 3, 2020
Merged
Conversation
- whenever overwriting `Border`'s `Coords` or `Coords/@points`, remove all the `Page`'s derived images with `cropped` - whenever overwriting `Region`'s or `TextLine`'s or `Word`'s or `Glyph`'s `Coords` or `Coords/@points`, remove all its derived images - whenever overwriting `Page`'s or `Region`'s `@orientation`, remove all its derived images with `deskewed` - add a warning to the GdsCollector each time
bc81f87 to
a8cd848
Compare
- whenever overwriting `Page`'s `Border`, remove all its derived images with `cropped`
This was referenced Oct 31, 2020
kba
approved these changes
Nov 2, 2020
Member
kba
left a comment
There was a problem hiding this comment.
LGTM, we should add unit tests though.
Collaborator
Author
Indeed. This is actually not that hard to do. For example, in
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the issue described in chat for all processors based on core Python. (Not sure about bashlib processors...)
(I added a warning to the default
GdsCollectorabout theAlternativeImageremoval. If and when #576 lands, these should appear in OCR-D logging somehow. 🤞)Thus, some workflows will work, while others will need to be re-defined.
As I said above, this still does not expose all bad workflows, as it depends whether processors make their image requirements explicit (
feature_selectorandfeature_filter) or not. If they do, we'll at least get exceptionsFound no AlternativeImage that satisfies all requirementswhen running invalid workflows. But if they don't, there might be strange errors (like when 3-dim integer arrays from raw RGB images are passed to algorithms that need 1-dim boolean arrays from binarization) or no errors at all (like when implicit internal binarization happens or denoising is simply missing).