Add check for pull requests (GitHub action)#892
Open
stweil wants to merge 1 commit intoOCR-D:masterfrom
Open
Conversation
Contributor
Author
|
See this example of a bad pull request which triggers a CI failure. |
stweil
force-pushed
the
ci
branch
2 times, most recently
from
aad6308 to
7b89d68
Compare
Signed-off-by: Stefan Weil <sw@weilnetz.de>
Contributor
Author
|
@kba, please merge. |
Contributor
Author
|
This new GitHub action currently checks pull requests for whitespace issues. It can be extended to
What formal checks for pull requests should be added? The action code includes code from https://github.com/JensDll/should-run. That is a GitHub action which could be used to select the CI tests depending on the changes made by a pull request. For example the pull request here does not change code, so running all CI tests is not necessary and currently wasting resources. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Weil sw@weilnetz.de