Conversation
bertsky
left a comment
There was a problem hiding this comment.
Should we explicitly mention presets as a special kind of resource?
And should we give a perspective on practical resource management with ocrd_all native and ocrd/all containers here? (Just asking, really.)
EEngl52
left a comment
There was a problem hiding this comment.
looks good to me. We should also adjust the example calls in the workflow guide
Co-authored-by: Robert Sachunsky <38561704+bertsky@users.noreply.github.com>
Co-authored-by: Elisabeth Engl <53007946+EEngl52@users.noreply.github.com>
Co-authored-by: Robert Sachunsky <38561704+bertsky@users.noreply.github.com>
Co-authored-by: Robert Sachunsky <38561704+bertsky@users.noreply.github.com>
Co-authored-by: Robert Sachunsky <38561704+bertsky@users.noreply.github.com>
Co-authored-by: Robert Sachunsky <38561704+bertsky@users.noreply.github.com>
Co-authored-by: Robert Sachunsky <38561704+bertsky@users.noreply.github.com>
Co-authored-by: Robert Sachunsky <38561704+bertsky@users.noreply.github.com>
Co-authored-by: Robert Sachunsky <38561704+bertsky@users.noreply.github.com>
Co-authored-by: Robert Sachunsky <38561704+bertsky@users.noreply.github.com>
Good point, I haven't been considering parameter presets, I'll have to make sure that it is properly covered and then document it. So I'll make another pre-release and do a proper release once I am sure we have this covered.
Yes! One reason for |
d886e68 @bertsky I don't have docker available right now, so I haven't tested this. Can you check please whether this works? In particular, what is |
|
Forgot to push?
HOME expands to
Yes, with |
…website into update-models-2.22.0
Yup, sry 😊 pushed it now.
Thanks for checking. |
There was a problem hiding this comment.
There were various inaccuracies in the commands, but more importantly, I don't think we should actually recommend that 2-step approach. You would still have to natively install core independent of Docker, which defeats the use-case for virtualization in the first place. (And in the future, we even want to aggregate the database from submodules on the fly, so a full-blown native ocrd_all installation would be necessary to download resources on the host.)
Instead, this alternative formulation just explains how to mount a persistent host directory for the models, and use Docker to download models into it whenever needed.
You're right, I didn't consider how you'd need a full deployment on the host to download the models outside of docker.
This works on the top-level venv but what about the sub-venvs? They have their own |
Co-authored-by: Robert Sachunsky <38561704+bertsky@users.noreply.github.com>
Co-authored-by: Robert Sachunsky <38561704+bertsky@users.noreply.github.com>
Co-authored-by: Robert Sachunsky <38561704+bertsky@users.noreply.github.com>
Co-authored-by: Robert Sachunsky <38561704+bertsky@users.noreply.github.com>
Co-authored-by: Robert Sachunsky <38561704+bertsky@users.noreply.github.com>
Co-authored-by: Robert Sachunsky <38561704+bertsky@users.noreply.github.com>
|
Sorry, I was not aware the markdown rendering is different on ocr-d.de. It did not take my four-space prefix as command syntax, we must change to code blocks (inside list items!) again... |
|
I was afraid so but didn't check. I'll prepare a fix. |
|
Also, we still need to explain that now processors will automatically download resources they need. (This is a bit surprising given all the |
|
Don't we mention "downloaded on-demand"? |
Now that you say it: yes, once, in a comment of a command for one processors' resources 😄 |
that's all a true hacker needs : Jest aside, I added a section on that in #197 |
No description provided.