[Integrate-1061] Enable upload / download for strategus results #1667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hengxian-jiang
requested review from
KangJingA,
SantanM,
csafreen,
p-hoffmann,
satish-a0 and
suwarnoong
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds support for uploading, downloading, listing, and deleting Strategus results files through a new set of storage APIs. The implementation creates dedicated endpoints for managing Strategus results stored in a separate Supabase storage bucket.
Changes:
- Added four new API endpoints for Strategus results management (upload, download, list, delete) with corresponding authorization scopes
- Implemented direct storage methods that bypass path transformation logic used by existing storage operations
- Created a new controller in jobplugins to handle Strategus results operations with file validation (zip files up to 500MB)
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 16 comments.
Show a summary per file
| File | Description |
|---|---|
| functions/portal/src/supabase-storage/supabase.storage.controller.ts | Added four new endpoints for Strategus results operations (upload/download/list/delete) with query parameter validation |
| functions/portal/src/supabase-storage/supabase.storage.client.ts | Implemented direct storage methods (uploadDirect, downloadDirect, deleteDirect, listByPrefix) and added strategus-results bucket initialization |
| functions/package.json | Added authorization scope configurations for the new Strategus results endpoints |
| functions/jobplugins/src/controllers/StrategusResultsController.ts | Created new controller with file validation, size limits, and error handling for Strategus results |
| functions/jobplugins/src/api/PortalServerAPI.ts | Added four client methods to interface with the new Strategus results storage endpoints and removed unused import |
| functions/jobplugins/index.ts | Registered the new StrategusResultsController route in the application |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
hengxian-jiang
requested review from
Zhimin-arya and
alicia-koh
as code owners
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
…rolled format string Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: hengxian-jiang <155619404+hengxian-jiang@users.noreply.github.com>
SantanM
reviewed
Jan 21, 2026
SantanM
reviewed
Jan 21, 2026
Collaborator
|
As discussed, please test the scenario when two set of results
The assumptions you can make are -
|
…esults_upload_download
…rolled format string Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> Signed-off-by: hengxian-jiang <155619404+hengxian-jiang@users.noreply.github.com>
SantanM
approved these changes
Jan 26, 2026
alicia-koh
approved these changes
Jan 26, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Checklist
Please cross check this list if additions / modifications needs to be done on top of your core changes and tick them off. Reviewer can as well glance through and help the developer if something is missed out.
developbranch)