-
Notifications
You must be signed in to change notification settings - Fork 9
Add d2e to prefect base path #1669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds "/d2e" as a base path for the Prefect server and upgrades Prefect from version 3.0.3 to 3.6.10. The changes enable Prefect to be served under a custom base path, which is necessary for proper routing through the application gateway.
Changes:
- Updated Prefect server configuration to serve API and UI under
/d2ebase path - Modified all client references to access Prefect API at the new
/d2e/apiendpoint - Upgraded Prefect Docker image from 3.0.3-python3.11 to 3.6.10-python3.12
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ui/apps/jobs/src/compositions/useApiConfig.ts | Updated Prefect API base URL from 'prefect/api' to 'prefect/d2e/api' |
| services/enterprise-gateway/r-strategus-lib/rD2E/R/strategus.R | Updated R library Prefect deployment URL to include '/d2e' path segment |
| services/alp-dataflow-gen-worker/Dockerfile | Upgraded Prefect version from 3.0.3-python3.11 to 3.6.10-python3.12 |
| scripts/check-setupdemohana-flow.mjs | Updated flow monitoring script to use new Prefect API path '/d2e/prefect/d2e/api' |
| scripts/check-setupdemo-flow.mjs | Updated flow monitoring script to use new Prefect API path '/d2e/prefect/d2e/api' |
| functions/package.json | Updated PREFECT_API_URL environment variables to include '/d2e/api' path |
| flows/hades/strategus_plugin/dc-local.yml | Updated local development Prefect API URL to include '/d2e/api' |
| flows/README.md | Updated documentation with new Prefect API configuration path |
| docker-compose.yml | Added Prefect server base path configuration and upgraded image version |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…com/OHDSI/Data2Evidence into alicia-koh/change-prefect-base-path
| @@ -1,3 +1,3 @@ | |||
| FROM prefecthq/prefect:3.0.3-python3.11 | |||
| FROM prefecthq/prefect:3.6.10-python3.12 | |||
|
|
|||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the existing system work fine after upgrade? especially with migration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just need to run prefect server database upgrade. Flows, jobs in portal, and etl ui works have been tested in new vm instance.
Upgrades prefect docker image from 3.0.3-python3.11 to 3.6.10-python3.12
Merge Checklist
Please cross check this list if additions / modifications needs to be done on top of your core changes and tick them off. Reviewer can as well glance through and help the developer if something is missed out.
developbranch)