Skip to content

Conversation

@satish-a0
Copy link
Collaborator

Merge Checklist

Please cross check this list if additions / modifications needs to be done on top of your core changes and tick them off. Reviewer can as well glance through and help the developer if something is missed out.

  • Automated Tests (Jasmine integration tests, Unit tests, and/or Performance tests)
  • Updated Manual tests / Demo Config
  • Documentation (Application guide, Admin guide, Markdown, Readme and/or Wiki)
  • Verified that local development environment is working with latest changes (integrated with latest develop branch)
  • following best practices in code review doc

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes the naming convention for the IS_SELF_MANAGED_ROLES environment variable to use lowercase snake_case (is_self_managed_roles) to comply with Prefect's variable naming requirements.

Changes:

  • Updated the environment variable mapping in TypeScript to use lowercase snake_case
  • Updated the Python code to reference the variable using the new lowercase naming convention

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
functions/alp-dataflow-gen-init/src/env.ts Added mapping for is_self_managed_roles from the IS_SELF_MANAGED_ROLES environment variable in the VARIABLES section
flows/_shared_flow_utils/create_dataset_tasks.py Updated Variable.get() call to use lowercase is_self_managed_roles instead of uppercase IS_SELF_MANAGED_ROLES

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants