Data characterisation chart axis optimisation #1692
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maggie-li-yd
requested review from
KangJingA and
hengxian-jiang
as code owners
maggie-li-yd
requested review from
SantanM,
p-hoffmann and
suwarnoong
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances chart axis formatting capabilities by allowing dynamic number formatting functions. The changes enable better display of large numbers on chart axes by abbreviating them (e.g., "10K", "1.5M") while maintaining flexibility for custom formatting logic.
Changes:
- Extended
yAxisFormattype to accept either a string or a formatting function - Added
formatLargeNumberutility function to abbreviate large numbers with K/M/B suffixes - Applied the new formatter to the ObservationPeriodObservedByMonthChart component
- Removed hardcoded grid positioning in LineChart to improve automatic layout
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| ui/apps/portal/src/plugins/SystemAdmin/DQD/types.ts | Extended LineChartFormatConfig to support function-based yAxisFormat |
| ui/apps/portal/src/components/Charts/util.ts | Updated getAxisNameGap to handle function formatters and added formatLargeNumber utility |
| ui/apps/portal/src/components/Charts/SourceKeys/ObservationPeriod/ObservationPeriodObservedByMonthChart/ObservationPeriodObservedByMonthChart.tsx | Applied formatLargeNumber to y-axis formatting |
| ui/apps/portal/src/components/Charts/Common/LineChart.tsx | Removed hardcoded left/bottom grid values, relying on containLabel |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ui/apps/portal/src/components/Charts/Reports/ObservationPeriod/ObservationPeriod.tsx
Outdated
Show resolved
Hide resolved
suwarnoong
approved these changes
Jan 23, 2026
maggie-li-yd
force-pushed
the
maggie-li-yd/1484-data-characterisation-chart-optimisation
branch
from
e6d89ce to
abcf991
Compare
maggie-li-yd
force-pushed
the
maggie-li-yd/1484-data-characterisation-chart-optimisation
branch
from
abcf991 to
08ad532
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Checklist
Please cross check this list if additions / modifications needs to be done on top of your core changes and tick them off. Reviewer can as well glance through and help the developer if something is missed out.
developbranch)