[Fix] cli composeFile #1706
[Fix] cli composeFile #1706
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aims to fix the passing of custom docker compose files by updating the CLI option definition for the compose file parameter.
Changes:
- Updated the
-coption from--compose-fileto--composeFile <path>and added the missing<path>parameter specification
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| .option("--hades", "") | ||
| .option( | ||
| "-c, --compose-file", | ||
| "-c, --composeFile <path>", |
There was a problem hiding this comment.
The CLI option naming is now inconsistent with other options in the same file. All other multi-word options use kebab-case (e.g., --function-path, --docker-context, --env-file), while this change introduces camelCase (--composeFile). Commander.js automatically converts kebab-case to camelCase when creating the options object, so --compose-file would still be accessible as options.composeFile. The fix should keep --compose-file for consistency with other options while only adding the missing <path> parameter specification.
| .option("--hades", "") | ||
| .option( | ||
| "-c, --compose-file", | ||
| "-c, --composeFile <path>", |
There was a problem hiding this comment.
This change introduces a breaking change to the CLI interface. Users who were previously using -c or --compose-file will need to update to --composeFile. While the internal code already expects composeFile, Commander.js automatically converts kebab-case option names to camelCase in the options object, so the original --compose-file would have worked correctly with options.composeFile. Consider the impact on existing users and scripts that may be using this CLI option.
| "-c, --composeFile <path>", | |
| "-c, --compose-file <path>", |
… mwaiyee/fix-cli-composeFile
Merge Checklist
Please cross check this list if additions / modifications needs to be done on top of your core changes and tick them off. Reviewer can as well glance through and help the developer if something is missed out.
developbranch)