Update CM module for CM v6 #277
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #277 +/- ##
===========================================
+ Coverage 97.82% 98.56% +0.73%
===========================================
Files 16 16
Lines 4193 5075 +882
===========================================
+ Hits 4102 5002 +900
+ Misses 91 73 -18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
* Updating evidence synthesis results schema fro balance diagnostic and target_comparator_id * Balance meta-analysis and switching to target_comnparator_id * Fixing balance meta-analysis * Formally importing pnorm from stats to avoid R check note --------- Co-authored-by: Admin_mschuemi <Admin_mschuemi@its.jnj.com>
anthonysena
commented
Jan 27, 2026
Comment on lines
+1142
to
+1150
| balance <- DatabaseConnector::renderTranslateQuerySql( | ||
| connection = connection, | ||
| sql = sql, | ||
| database_schema = databaseSchema, | ||
| database_ids = if (is.null(databaseIds)) "" else private$.quoteSql(databaseIds), | ||
| analysis_ids = if (is.null(analysisIds)) "" else analysisIds, | ||
| snakeCaseToCamelCase = TRUE | ||
| ) |> | ||
| as_tibble() |
Collaborator
Author
There was a problem hiding this comment.
@schuemie - when constructing the balance, it is possible that 0 analyses will pass diagnostics (i.e. rows with unblind_for_evidence_synthesis = 1 will be 0 imposed by the query above). When this happens, the remainder of the function fails since it assumes balance has data. Not sure how to gracefully handle this here so just putting a note so you can take a look.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to support CohortMethod v6 and to require the use of CohortGenerator v1.