Skip to content

Conversation

@catenacyber
Copy link
Contributor

@catenacyber catenacyber commented Dec 14, 2025

Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/3464

Describe changes:

  • define feature UNIX_SOCKET if compiled in

SV_BRANCH=OISF/suricata-verify#2836

#14473 just rebased to run new SV PR

for SV tests to tun conditionnaly on it

Ticket: 3464
@codecov
Copy link

codecov bot commented Dec 14, 2025

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.13%. Comparing base (a53ba4a) to head (e2285bf).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14493      +/-   ##
==========================================
+ Coverage   82.11%   82.13%   +0.02%     
==========================================
  Files        1013     1013              
  Lines      262322   262325       +3     
==========================================
+ Hits       215408   215471      +63     
+ Misses      46914    46854      -60     
Flag Coverage Δ
fuzzcorpus 59.30% <0.00%> (+<0.01%) ⬆️
livemode 18.91% <0.00%> (+0.03%) ⬆️
pcap 44.69% <0.00%> (+0.05%) ⬆️
suricata-verify 65.28% <0.00%> (+0.28%) ⬆️
unittests 59.26% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@suricata-qa
Copy link

Information: QA ran without warnings.

Pipeline = 28772

Copy link
Member

@jasonish jasonish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense to have this.

@catenacyber
Copy link
Contributor Author

Make sense to have this.

Thanks Jason, but the main PR is the SV one here ;-) could you look at it and approve it if ok ?

@victorjulien
Copy link
Member

Passed my QA. Ran this PR with SV PR OISF/suricata-verify#2818. Local pipeline 6051, run 1158.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants