Bindgen more 7762 v8.3.1 #14579
Open
Bindgen more 7762 v8.3.1 #14579
+157
−222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It does not return anything. The only known implementation is in dns where it does not return. And the C code does not bother to check a return value anyways.
That is what bindgen will do
just use an u32 out of the box. Will make bindgen like easier
Will make bindgen life easier As the fn prototype should not have istate: &mut u64 but a *mut AppLayerGetTxIterState which is an union with a u64
Will make bindgen life easier As the fn prototype should not have istate: &mut u64 but a *mut AppLayerGetTxIterState which is an union with a u64
As will be needed such as AppLayerTxData
catenacyber
requested review from
a team,
jasonish,
jufajardini and
victorjulien
as code owners
This was referenced Jan 8, 2026
So, fix the fn prototype in rust ParseFn
catenacyber
force-pushed
the
bindgen-more-7762-v8.3.1
branch
from
d190072 to
f508e02
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #14579 +/- ##
==========================================
- Coverage 82.16% 82.16% -0.01%
==========================================
Files 1013 1013
Lines 262387 262345 -42
==========================================
- Hits 215598 215544 -54
- Misses 46789 46801 +12
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Information: QA ran without warnings. Pipeline = 29020 |
1 similar comment
|
Information: QA ran without warnings. Pipeline = 29020 |
Contributor
Author
|
Next steps
|
jasonish
reviewed
Jan 9, 2026
| --disable-header-comment \ | ||
| --default-enum-style rust \ | ||
| --with-derive-default \ | ||
| --with-derive-eq \ |
Member
There was a problem hiding this comment.
But we don't need it yet right?
Contributor
Author
There was a problem hiding this comment.
No, we need it with last commit of #14556
Member
There was a problem hiding this comment.
Just looks out of place in this PR where it has no usage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to ticket: https://redmine.openinfosecfoundation.org/issues/
https://redmine.openinfosecfoundation.org/issues/7762
Describe changes:
#14555 with mut local storage