jhrg/libdap4 305 serialization bug

[jgallagher59701]

This is a fix for issue 305.

[jgallagher59701]

Based on recent feedback from NSIDC, we are going to have to test this against the Unidata Java client code, beyond that, it's ready for review.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
80.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[ndp-opendap]

The checksum problem may be at play here as well. You might try modifying the ncdump URL to ask for checksums, which I think will cause ncdump to expect them? Not sure...

[ndp-opendap]

Sorry about my confusion:

The changes have been merged to master, but they only affect the NGAP api endpoint.

• If your data access URL path ends with a NASA restified path (collections/collection-id/granules/granule-ur) the the response will contain checksums. Period. Even if you add the dap4.checksum=false KVP to the query string they will still be sent.
• Otherwise, for all other DAP4 data requests, the checksum are still optional and may only be requested by adding the dap4.checksum=true KVP to the query string

[jgallagher59701]

NB: This also relates to, and fixes, EED3 issue HYRAX-1867.

[jgallagher59701]

Make a test deployment of Hyrax that contains this and put it on UAT and make sure that NSIDC's application (OA) still works.

[jgallagher59701]

@ndp-opendap @Mikejmnez Please review this so I can start the process today of getting this to SIT.

[ndp-opendap]

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
77.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[jgallagher59701]

Tested against OA in UAT. Works - see ticket for details (https://bugs.earthdata.nasa.gov/browse/HYRAX-1948)