Jhrg/hyrax-1963 dmr version bump #320
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This indicates the change in the serialization algorithm to match the DAP4 specification.
|
ndp-opendap
approved these changes
Dec 17, 2025
Contributor
ndp-opendap
left a comment
ndp-opendap
left a comment
There was a problem hiding this comment.
My only concern about this is that nothing whatsoever has changed in the DMR XML representation, it's the serialization order that has changed...
hannahilea
approved these changes
Dec 17, 2025
Contributor
hannahilea
left a comment
hannahilea
left a comment
There was a problem hiding this comment.
lgtm. let's wait to merge until we have a (passing) bes branch ready to merge immediately after.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the dmrVersion XML attribute from 1.0 to 2.0 (the change in DMR serialization makes the two responses incompatible).
I fixed the test baselines. All the tests pass.
This change will break a number of BES tests. So facr, the only change to the baselines has been to change "1.0" to "2.0".