Add support for subset by value in the DAP4 CE syntax #322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What is not so good is that a problem shows up. Using the new syntax [(45.6)] fails because the '.' scans as a PATH_SEP, and that breaks everything. This is why I added NUMBER before. But, that causes its own set of parsing issues. Try FLOAT and add rules in the parser for both [(FLOAT)] and [(WORD)]?
Contributor
|
To be clear, are you talking about implementing what is described on the ERDDAP/GridDap web page? |
…dap4 into jhrg/subset-by-value
Also, added to the cmake README more info about actually using cmake for the builds.
This just sets any value-based dimension subset to 0:1:0. This shows that parsing works. The next step - to determine the indices based on values, is going to be left until the grid/geogrid functions are done.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have had a long-standing back-and-forth regarding the ERDDAP notation for value based subsetting. I thought I'd revisiting the issue and take this opportunity to update the grid() and maybe geogrid() server functions so they work with DAP4. This branch is the start of that, looking at the syntax that ERDDAP uses and modifying the DAP4 CE parser to recognize it.