Minor HDF5 refactor and drop the rotational DOFs #843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
jenkins build this with downstreams please |
akva2
reviewed
Dec 9, 2025
Changed: Use std::to_string() instead of std::stringstream.
Contributor
Author
|
jenkins build this with downstreams please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding two convenience methods doing some repetitive tasks, also using
std::to_string()instead ofstd::stringstream(more compact). Then removing the three rotational DOFs if there are 6 DOFs per node (assuming the 3 rotations are ordered after the translations per node. They are not needed for visualizing deformations.May consider adding them purely as scalar fields instead?
Not tested (since the current version of SISO only supports hex elements).