Skip to content

Conversation

@markusjt
Copy link

@markusjt markusjt commented Dec 18, 2025

Adds a page about CESSDA SKG-IF API in SKG Tools. I had to add some notes and a warning on the page due to there being some issues currently that will hopefully be fixed soon but might actually not happen until January.

Edit: Changed to draft as there is a chance that these issues will be fixed tomorrow so I'll change this back to ready for review tomorrow (19 Dec) afternoon.

@markusjt markusjt marked this pull request as draft December 18, 2025 11:51
@markusjt markusjt marked this pull request as ready for review December 19, 2025 12:07
@MarekSuchanek MarekSuchanek requested review from TomMiksa and andresTabiTuwien and removed request for MarekSuchanek December 23, 2025 07:47
@MarekSuchanek
Copy link
Member

@markusjt there are conflicts again... can you either give me access so I can rebase and directly merge or can you rebase and let me know? Seems there are conflicts in SKG.rst where style was changed (4 space indentation instead of 3).

@markusjt
Copy link
Author

@markusjt there are conflicts again... can you either give me access so I can rebase and directly merge or can you rebase and let me know? Seems there are conflicts in SKG.rst where style was changed (4 space indentation instead of 3).

Does it work now? I fetched upstream and rebased but somehow made a slight mistake somewhere I think as then I had 3 space indentation for the tools in SKG.rst only so I fixed that in a separate commit.

@MarekSuchanek MarekSuchanek merged commit e1d7726 into OSTrails:commons-deliverable-m24 Jan 16, 2026
1 check passed
@MarekSuchanek
Copy link
Member

Thanks, I merged it to avoid any more of unnecessary rebasing... @TomMiksa and @andresTabiTuwien can then do adjustments as part of #22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants