Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this PR I have addressed the failing CRF calculation if no discount rate is provided (which was partially addressed in PR #216). Following @willu47's suggestion in ticket #217, the
_expand_default()function is used to ensure discount rate data is always passed into the CRF, PVA, and Discount Factor functions. Since handling theDiscountRateandDiscountRateIdvdifferences is a little confusing (imo), I also added inValueErrorchecks to the functions to check for non-empty discount rates - but these shouldnt really be needed. Just added as double check.Issue Ticket Number
closes #217
Documentation
na