Skip to content

Conversation

@Aut0R3V
Copy link

@Aut0R3V Aut0R3V commented Jan 1, 2021

I felt like there could be a little bit of work done here. Please add in any comments of changes. I'll add in more stuff soon if PR's are accepted here.

@Aut0R3V
Copy link
Author

Aut0R3V commented Jan 1, 2021

@drwetter @wurstbrot

@drwetter
Copy link
Collaborator

drwetter commented Jan 2, 2021

Hi @Aut0R3V ,

thanks!

The introductory section though should rather give a broad with an overview. Also I would like to avoid the term 'docker secrets' here as it was/is used in correlation with docker swarm. Also docker swarm is listed specifically there.

So everybody else not using docker swarm will scratch their heads what this will be about.

The first paragraph should contain as a very first thing a definition what a secret is. Also it's not only about keys or certificates about secure transmission. The transmission can also be clear text, also when it maybe discouraged from using it. E.g. as a matter of fact, often it -- when using a DB connector.

I'll try to make a counter suggestion (=PR) the next few days.

@Aut0R3V
Copy link
Author

Aut0R3V commented Jan 2, 2021

@drwetter actually I wanted to know if PR's are being accepted. I can add a proper introduction with the added comments. I'd also like to work on the other sections in D06.

@drwetter
Copy link
Collaborator

drwetter commented Jan 2, 2021

To add: The introductory section should always be high level. If we start with low level tech stuff there we loose people upfront

@Aut0R3V
Copy link
Author

Aut0R3V commented Jan 2, 2021

Sure thanks! I'll send in a commit soon.

@drwetter
Copy link
Collaborator

drwetter commented Jan 2, 2021

PR #38 is not superb but it's definitely closer to what I think it should be like. So I am closing this one.

Feel free comment on #38 or send in PRs to the d06_intro branch

@drwetter drwetter closed this Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants