Skip to content

Conversation

@magicxyyz
Copy link
Contributor

@magicxyyz magicxyyz commented Nov 24, 2025

Resolves NIT-4138

This PR disables opening ancients for classic-msg database. Previously, due to upstream geth change in opening databases, default attempt to open ancients failed for classic-msg, causing the node to ignore the database.
Related issue was already fixed for arbitrumdata and wasm databases in #3828, but the fix missed classic-msg db.

@github-actions
Copy link

github-actions bot commented Nov 24, 2025

❌ 8 Tests Failed:

Tests completed Failed Passed Skipped
4445 8 4437 0
View the top 3 failed tests by shortest run time
TestRedisProduceComplex/two_producers,_some_consumers_killed,_others_should_take_over_their_work,_some_invalid_entries,_unequal_number_of_requests_from_producers
Stack Traces | 2.170s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
�[36mDEBUG�[0m[12-19|10:45:43.345] request timed out waiting for response   �[36mmsgId�[0m=1766141141341-20 �[36mallowedOldestId�[0m=1766141141343-0
�[36mDEBUG�[0m[12-19|10:45:43.345] checkResponses                           �[36mresponded�[0m=0   �[36merrored�[0m=4 �[36mchecked�[0m=8
�[36mDEBUG�[0m[12-19|10:45:43.349] redis producer: check responses starting
�[36mDEBUG�[0m[12-19|10:45:43.349] checkResponses                           �[36mresponded�[0m=0   �[36merrored�[0m=0 �[36mchecked�[0m=0
�[36mDEBUG�[0m[12-19|10:45:43.350] redis producer: check responses starting
�[36mDEBUG�[0m[12-19|10:45:43.351] request timed out waiting for response   �[36mmsgId�[0m=1766141141343-18 �[36mallowedOldestId�[0m=1766141141351-0
�[36mDEBUG�[0m[12-19|10:45:43.352] request timed out waiting for response   �[36mmsgId�[0m=1766141141343-20 �[36mallowedOldestId�[0m=1766141141351-0
�[36mDEBUG�[0m[12-19|10:45:43.352] request timed out waiting for response   �[36mmsgId�[0m=1766141141343-19 �[36mallowedOldestId�[0m=1766141141351-0
�[36mDEBUG�[0m[12-19|10:45:43.352] request timed out waiting for response   �[36mmsgId�[0m=1766141141343-21 �[36mallowedOldestId�[0m=1766141141351-0
�[36mDEBUG�[0m[12-19|10:45:43.352] checkResponses                           �[36mresponded�[0m=0   �[36merrored�[0m=4 �[36mchecked�[0m=4
    pubsub_test.go:383: Unexpected error while awaiting responses, producer: 1, response: 152, err: error getting response, request has been waiting for too long
    pubsub_test.go:383: Unexpected error while awaiting responses, producer: 1, response: 153, err: error getting response, request has been waiting for too long
    pubsub_test.go:383: Unexpected error while awaiting responses, producer: 1, response: 154, err: error getting response, request has been waiting for too long
    pubsub_test.go:383: Unexpected error while awaiting responses, producer: 1, response: 155, err: error getting response, request has been waiting for too long
    pubsub_test.go:383: Unexpected error while awaiting responses, producer: 1, response: 196, err: error getting response, request has been waiting for too long
    pubsub_test.go:383: Unexpected error while awaiting responses, producer: 1, response: 197, err: error getting response, request has been waiting for too long
    pubsub_test.go:383: Unexpected error while awaiting responses, producer: 1, response: 198, err: error getting response, request has been waiting for too long
    pubsub_test.go:383: Unexpected error while awaiting responses, producer: 1, response: 199, err: error getting response, request has been waiting for too long
�[36mDEBUG�[0m[12-19|10:45:43.452] Error destroying a stream group          �[36merror�[0m="dial tcp 127.0.0.1:46331: connect: connection refused"
--- FAIL: TestRedisProduceComplex/two_producers,_some_consumers_killed,_others_should_take_over_their_work,_some_invalid_entries,_unequal_number_of_requests_from_producers (2.17s)
TestOutOfGasInStorageCacheFlush
Stack Traces | 5.350s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
=== CONT  TestOutOfGasInStorageCacheFlush
    common_test.go:693: BuildL1 deployConfig: DeployBold=false, DeployReferenceDAContracts=false
    program_test.go:2832: goroutine 844911 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.5/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x40f16d0, 0xc138cbb500}, {0x40ae920, 0xc18f8a9e80}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/system_tests.Require(0xc138cbb500, {0x40ae920, 0xc18f8a9e80}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:2003 +0x5d
        github.com/offchainlabs/nitro/system_tests.TestOutOfGasInStorageCacheFlush(0xc138cbb500)
        	/home/runner/work/nitro/nitro/system_tests/program_test.go:2832 +0x1006
        testing.tRunner(0xc138cbb500, 0x3d30e60)
        	/opt/hostedtoolcache/go/1.25.5/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.5/x64/src/testing/testing.go:1997 +0x465
        
    program_test.go:2832: �[31;1m [] failed calculating position for validation: batch not found on L1 yet �[0;0m
INFO [12-19|10:56:40.703] HTTP server stopped                      endpoint=127.0.0.1:45341
TRACE[12-19|10:56:40.703] P2P networking is spinning down
--- FAIL: TestOutOfGasInStorageCacheFlush (5.35s)
TestVersion30
Stack Traces | 5.920s run time
... [CONTENT TRUNCATED: Keeping last 20 lines]
�[38;5;48;1myay!! we validated block 9 in 417.30ms�[0;0m
�[38;5;48;1myay!! we validated block 7 in 346.03ms�[0;0m
    precompile_inclusion_test.go:94: goroutine 611012 [running]:
        runtime/debug.Stack()
        	/opt/hostedtoolcache/go/1.25.5/x64/src/runtime/debug/stack.go:26 +0x5e
        github.com/offchainlabs/nitro/util/testhelpers.RequireImpl({0x40f16d0, 0xc00ab90a80}, {0x40aeda0, 0xc15d515020}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/util/testhelpers/testhelpers.go:29 +0x55
        github.com/offchainlabs/nitro/system_tests.Require(0xc00ab90a80, {0x40aeda0, 0xc15d515020}, {0x0, 0x0, 0x0})
        	/home/runner/work/nitro/nitro/system_tests/common_test.go:2003 +0x5d
        github.com/offchainlabs/nitro/system_tests.testPrecompiles(0xc00ab90a80, 0x1e, {0xc096b71db0, 0x6, 0xc056ad5c10?})
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:94 +0x371
        github.com/offchainlabs/nitro/system_tests.TestVersion30(0xc00ab90a80?)
        	/home/runner/work/nitro/nitro/system_tests/precompile_inclusion_test.go:67 +0x798
        testing.tRunner(0xc00ab90a80, 0x3d31340)
        	/opt/hostedtoolcache/go/1.25.5/x64/src/testing/testing.go:1934 +0xea
        created by testing.(*T).Run in goroutine 1
        	/opt/hostedtoolcache/go/1.25.5/x64/src/testing/testing.go:1997 +0x465
        
    precompile_inclusion_test.go:94: �[31;1m [] execution aborted (timeout = 5s) �[0;0m
--- FAIL: TestVersion30 (5.92s)

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@magicxyyz magicxyyz changed the title don't open ancients for classic-msg database fix opening classic-msg database Dec 1, 2025
@codecov
Copy link

codecov bot commented Dec 19, 2025

Codecov Report

❌ Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 33.29%. Comparing base (5b59a1a) to head (2ef0fe3).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4065      +/-   ##
==========================================
- Coverage   33.35%   33.29%   -0.07%     
==========================================
  Files         453      453              
  Lines       55536    55542       +6     
==========================================
- Hits        18524    18492      -32     
- Misses      33774    33802      +28     
- Partials     3238     3248      +10     

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants