[Mel] - Create MEL validator #4152
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Message extraction function works with logs instead of receipts
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## raul/mel-inbox-reading #4152 +/- ##
==========================================================
- Coverage 29.29% 29.15% -0.14%
==========================================================
Files 457 460 +3
Lines 55861 56013 +152
==========================================================
- Hits 16362 16331 -31
- Misses 36542 36713 +171
- Partials 2957 2969 +12 |
❌ 799 Tests Failed:
View the top 3 failed tests by shortest run time
📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
rauljordan
reviewed
Dec 19, 2025
|
|
||
| func (mv *MELValidator) Start(ctx context.Context) { | ||
| mv.CallIteratively(func(ctx context.Context) time.Duration { | ||
| latestStaked, err := mv.rollup.LatestStakedAssertion(&bind.CallOpts{}, mv.boldStakerAddr) |
Contributor
There was a problem hiding this comment.
This will only work if the current node's mv.boldStakerAddress is the one that is staked on the chain (needs $10 million USD). We should instead fetch the latest assertion we locally agree with. I think we need to expose a helper method for this, and I can do this once I return from holiday
rauljordan
reviewed
Dec 19, 2025
| if state.Hash() != wantState.Hash() { | ||
| return nil, fmt.Errorf("calculated MEL state hash in recording mode doesn't match the one computed in native mode, parentchainBlocknumber: %d", i) | ||
| } | ||
| if state.MsgCount >= toValidateMsgExtractionCount { |
rauljordan
reviewed
Dec 19, 2025
| melValidator := staker.NewMELValidator(builder.L2.ConsensusNode.ArbDB, builder.L1.Client, builder.L2.ConsensusNode.MessageExtractor, blobReaderRegistry) | ||
| extractedMsgCount, err := builder.L2.ConsensusNode.TxStreamer.GetMessageCount() | ||
| Require(t, err) | ||
| entry, err := melValidator.CreateNextValidationEntry(ctx, startBlock, uint64(extractedMsgCount)) |
Contributor
There was a problem hiding this comment.
To test out multiple validations, we'll probably need to setup assertion posting...I can also help with this once Im back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.