Skip to content

Conversation

@thure
Copy link
Contributor

@thure thure commented May 9, 2022

This PR configures Storybook to use the Vite builder.

Caveats

  • Some dev dependencies that are implicit can’t be found by Vite, so they're hoisted directly to devDependencies along with iterall (which pnpm recommends as an alternative to having to --shamefully-hoist) to fix Storybook’s build.

@changeset-bot
Copy link

changeset-bot bot commented May 9, 2022

🦋 Changeset detected

Latest commit: 911ffff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@fluent-blocks/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@thure thure marked this pull request as draft May 10, 2022 00:01
@thure
Copy link
Contributor Author

thure commented May 10, 2022

Vite is causing many Playwright tests to take longer than 5s. Working with the community on Discord to resolve. Till then, putting this in draft state.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants