fix: propagate context to GetVehicleForTrip to prevent db connection leaks#473
Open
ARCoder181105 wants to merge 1 commit intoOneBusAway:mainfrom
Open
fix: propagate context to GetVehicleForTrip to prevent db connection leaks#473ARCoder181105 wants to merge 1 commit intoOneBusAway:mainfrom
ARCoder181105 wants to merge 1 commit intoOneBusAway:mainfrom
Conversation
…leaks - Updated `GetVehicleForTrip` in `gtfs_manager.go` to accept `context.Context` instead of using an isolated `context.Background()`. - Updated downstream caller handlers to pass the HTTP request context. - Ensures database queries tied to dropped HTTP requests are cancelled immediately, protecting the connection pool under heavy load.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves a stability issue where orphaned database queries were not properly cancelled when HTTP clients disconnected early.
GetVehicleForTrippreviously spun up an isolatedcontext.Background()with a hardcoded timeout, leading to potential database connection pool exhaustion under heavy load or client disconnects.Changes Made
internal/gtfs/gtfs_manager.go:GetVehicleForTripnow accepts and wraps the HTTP request context.arrival_and_departure_for_stop_handler.goandarrivals_and_departure_for_stop.go) to properly passr.Context()toGetVehicleForTrip.gtfs_manager_test.goto provide a context in test cases.defer cancel()execution to prevent memory leaks on the context tree.GtfsDB.Queriessuccessfully inherit the propagated context.make fmt,make lint, andmake testsuccessfully.Closes #472