fix(core): fix cosmos signing issue

[somebodyLi]

Summary by CodeRabbit

• Refactor
  • Improved internal handling of transaction data for increased clarity and control during deserialization. No visible changes to user-facing features.

[coderabbitai]

Walkthrough

This change adds two module-level lists for required and optional keys in a Cosmos transaction. It updates the MessageArgs namedtuple to use these keys. The Transaction.deserialize method now checks for required keys using the new list and constructs MessageArgs with explicit arguments.

Changes

File(s)	Change Summary
core/src/apps/cosmos/transaction.py	Added required_keys and _optional_keys lists; updated MessageArgs to use required_keys; changed Transaction.deserialize to use explicit argument passing and key checks.

Sequence Diagram(s)

sequenceDiagram
    participant Caller
    participant Transaction
    participant MessageArgs

    Caller->>Transaction: deserialize(raw_message)
    Transaction->>Transaction: Parse JSON payload
    Transaction->>Transaction: Check for each key in required_keys
    Transaction->>MessageArgs: Construct with explicit arguments from JSON
    Transaction-->>Caller: Return Transaction instance

Loading

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Pylint (3.3.7)

core/src/apps/cosmos/transaction.py

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary or Summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 9c8924a and 982c139.

📒 Files selected for processing (1)

• core/src/apps/cosmos/transaction.py (2 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

core/src/apps/cosmos/transaction.py (1)

crypto/tests/test_wycheproof.py (1)

• DataError (56-57)

🪛 Ruff (0.11.9)

core/src/apps/cosmos/transaction.py

230-230: Avoid specifying long messages outside the exception class

(TRY003)

---

239-239: Trailing comma missing

Add trailing comma

(COM812)

⏰ Context from checks skipped due to timeout of 90000ms (4)

• GitHub Check: Style check
• GitHub Check: Defs check
• GitHub Check: Gen check
• GitHub Check: Analyze (python)

🔇 Additional comments (3)

core/src/apps/cosmos/transaction.py (3)

11-12: Good centralization of key definitions.

This improves maintainability by defining keys in one place. The separation between required and optional keys is clear.

---

15-15: Consistent with the new key management approach.

Using required_keys maintains consistency and reduces duplication.

---

229-230: Improved validation using centralized key list.

This change makes the required key validation more maintainable and consistent.

🧰 Tools

🪛 Ruff (0.11.9)

230-230: Avoid specifying long messages outside the exception class

(TRY003)