test: add gas usage tests for updateMiddlewareDataHash (fixes #1)#16
Open
RonTuretzky wants to merge 1 commit intodevfrom
Open
test: add gas usage tests for updateMiddlewareDataHash (fixes #1)#16RonTuretzky wants to merge 1 commit intodevfrom
RonTuretzky wants to merge 1 commit intodevfrom
Conversation
- Created comprehensive gas tests to measure usage with varying operator counts and history lengths - Tests confirm the function exceeds block gas limits with 500+ operators or 100+ history entries - Added detailed findings document with risk assessment and recommendations - Gas usage shows super-linear growth with both operator count and history length Key findings: - 500 operators: 128% of block limit (EXCEEDS) - 100 history entries with 100 operators: 175% of block limit (EXCEEDS) - Critical threshold: ~400 operators or ~80 history entries - Recommended solutions: multi-step updates, history trimming, or pagination 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
updateMiddlewareDataHashfunction to address issue Check thatupdateMiddlewareDataHashfunction won't pass gas block limit #1Changes
MiddlewareShimGasTest.t.solwith multiple test scenarios:GAS_FINDINGS.mddocumentation with detailed analysisKey Findings
Gas Usage Exceeds Block Limits:
Growth Rates:
Safe Operating Thresholds:
Recommendations
Test Results
All gas tests pass and provide clear metrics:
Related Issues
Fixes #1
🤖 Generated with Claude Code