fix: refactor e2e test to support dynamic operator amounts#18
Open
RonTuretzky wants to merge 1 commit intodevfrom
Open
fix: refactor e2e test to support dynamic operator amounts#18RonTuretzky wants to merge 1 commit intodevfrom
RonTuretzky wants to merge 1 commit intodevfrom
Conversation
- Refactor CheckSignature.s.sol to dynamically read operator count from env - Update run-check-signatures.sh to support OPERATOR_NAMES env variable - Remove hardcoded 3-operator limitation - Add documentation for dynamic operator configuration The e2e tests now support any number of operators via the OPERATOR_NAMES environment variable (defaults to "testacc1,testacc2,testacc3"). 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
Fixes #3 - The e2e test was previously configured to run with only 3 operators. Running with a different amount of operators was only partially supported, most notably in
CheckSignature.solwhere the number of operators was hardcoded.Changes
1. CheckSignature.s.sol
operator1,operator2,operator3) with dynamic arrays_readOperators()function that reads operator names from environment variable2. run-check-signatures.sh
OPERATOR_NAMESenvironment variable3. Documentation
Usage
Test Plan
🤖 Generated with Claude Code