[dart-dio] [dart] Unify both dart generators into just dart#14346
Closed
ahmednfwela wants to merge 22 commits intoOpenAPITools:masterfrom
Closed
[dart-dio] [dart] Unify both dart generators into just dart#14346ahmednfwela wants to merge 22 commits intoOpenAPITools:masterfrom
dart#14346ahmednfwela wants to merge 22 commits intoOpenAPITools:masterfrom
Conversation
…to fix-non-legacy-discriminator-behavior
wing328
reviewed
Jan 2, 2023
| hideGenerationTimestamp: "true" | ||
| enumUnknownDefaultCase: "true" | ||
| serializationLibrary: "built_value" | ||
| networkingLibrary: "dio" |
Member
There was a problem hiding this comment.
What about using library (global option, not generator option) instead?
Contributor
Author
There was a problem hiding this comment.
currently the serializationLibrary is assigned to library global option (this was introduced in #9980)
I was going to make another PR that targets v7.0.0, with the correct parameters assigned, but I am not sure if this is the right approach
Contributor
Author
There was a problem hiding this comment.
…to dart-dio/optional-http-library
This was referenced May 5, 2023
dart
This was referenced May 13, 2023
Contributor
Author
|
Replaced by #15485 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
based on: #14291
Blocked on:
this PR adds support for using http library instead of dio
it's still WIP and highly experimental, suggestions welcome
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(6.3.0) (minor release - breaking changes with fallbacks),7.0.x(breaking changes without fallbacks)