-
-
Notifications
You must be signed in to change notification settings - Fork 7.3k
[rust] support discriminators on existing fields #22489
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
I just noticed that my code injects discriminator fields that were not present before in some samples like in |
|
It's even worse, in the |
|
Weird, the CI fails on tests unrelated to my changes: |
|
@frol @farcaller @richardwhiuk @paladinzh @jacob-pro @dsteeley Hi, I opened this PR to fix #22344. The CI fails but it seems unrelated to my changes. Can anyone help me figure out the issue? |
|
@ThomasVille, unsure on the failure but does look to be impacting other PRs so potentially unrelated to your changes here. |
|
I'm not an expert on the Rust client generator but assuming you've tested out this function it looks sensible to me. |
Fixes #22344.
When a
discriminatoris specified foroneOfand the field is also a required field in one of the possible variants ofoneOf,set a default value for that field, otherwise
serdewill fail to parse it because it removes thetaginternally.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
master(upcoming7.x.0minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks)"fixes #123"present in the PR description)