Skip to content

Upstream PR #4588: PubMatic: Pass alias bidder name through (#4588) #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
openads-sync-bot wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Upstream PR #4588: PubMatic: Pass alias bidder name through (#4588) #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ea84983
PubMatic: Pass alias bidder name through (#4588)
Pubmatic-Supriya-Patil Nov 11, 2025
6128b9a
Merge branch 'main' into sync/upstream-pr-4588
jbingham94 Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions adapters/pubmatic/pubmatic.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ const MAX_IMPRESSIONS_PUBMATIC = 30

const ae = "ae"

const BidderPubMatic = "pubmatic"

type PubmaticAdapter struct {
URI string
bidderName string
Expand All @@ -37,8 +39,9 @@ type pubmaticBidExt struct {
}

type pubmaticWrapperExt struct {
ProfileID int `json:"profile,omitempty"`
VersionID int `json:"version,omitempty"`
ProfileID int `json:"profile,omitempty"`
VersionID int `json:"version,omitempty"`
BidderCode string `json:"biddercode,omitempty"`
}

type pubmaticBidExtVideo struct {
Expand Down Expand Up @@ -386,6 +389,19 @@ func extractPubmaticExtFromRequest(request *openrtb2.BidRequest) (extRequestAdSe
pmReqExt.Wrapper = wrpExt
}

if pmReqExt.Wrapper == nil {
pmReqExt.Wrapper = &pubmaticWrapperExt{}
}

// Always set bidder code to default
pmReqExt.Wrapper.BidderCode = BidderPubMatic

// Override bidder code if alias exists
for alias := range reqExt.Prebid.Aliases {
pmReqExt.Wrapper.BidderCode = alias
break
}

if acatBytes, ok := reqExtBidderParams["acat"]; ok {
var acat []string
err = jsonutil.Unmarshal(acatBytes, &acat)
Expand Down
34 changes: 29 additions & 5 deletions adapters/pubmatic/pubmatic_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ func TestExtractPubmaticExtFromRequest(t *testing.T) {
Ext: json.RawMessage(`{"prebid":{"bidderparams":{}}}`),
},
},
expectedReqExt: extRequestAdServer{},
expectedReqExt: extRequestAdServer{Wrapper: &pubmaticWrapperExt{ProfileID: 0, VersionID: 0, BidderCode: "pubmatic"}},
wantErr: false,
},
{
Expand All @@ -296,7 +296,7 @@ func TestExtractPubmaticExtFromRequest(t *testing.T) {
},
},
expectedReqExt: extRequestAdServer{
Wrapper: &pubmaticWrapperExt{ProfileID: 123, VersionID: 456},
Wrapper: &pubmaticWrapperExt{ProfileID: 123, VersionID: 456, BidderCode: "pubmatic"},
},
wantErr: false,
},
Expand All @@ -317,7 +317,7 @@ func TestExtractPubmaticExtFromRequest(t *testing.T) {
},
},
expectedReqExt: extRequestAdServer{
Wrapper: &pubmaticWrapperExt{ProfileID: 123, VersionID: 456},
Wrapper: &pubmaticWrapperExt{ProfileID: 123, VersionID: 456, BidderCode: "pubmatic"},
Acat: []string{"drg", "dlu", "ssr"},
},
wantErr: false,
Expand All @@ -330,7 +330,7 @@ func TestExtractPubmaticExtFromRequest(t *testing.T) {
},
},
expectedReqExt: extRequestAdServer{
Wrapper: &pubmaticWrapperExt{ProfileID: 123, VersionID: 456},
Wrapper: &pubmaticWrapperExt{ProfileID: 123, VersionID: 456, BidderCode: "pubmatic"},
},
wantErr: true,
},
Expand All @@ -343,7 +343,31 @@ func TestExtractPubmaticExtFromRequest(t *testing.T) {
},
expectedReqExt: extRequestAdServer{
Marketplace: &marketplaceReqExt{AllowedBidders: []string{"pubmatic", "groupm"}},
Wrapper: &pubmaticWrapperExt{ProfileID: 123, VersionID: 456},
Wrapper: &pubmaticWrapperExt{ProfileID: 123, VersionID: 456, BidderCode: "pubmatic"},
},
wantErr: false,
},
{
name: "Valid_request_ext_with_alias",
args: args{
request: &openrtb2.BidRequest{
Ext: json.RawMessage(`{"prebid":{"aliases":{"pubmatic-1":"pubmatic"},"bidderparams":{"wrapper":{"profile":123,"version":456}}}}`),
},
},
expectedReqExt: extRequestAdServer{
Wrapper: &pubmaticWrapperExt{ProfileID: 123, VersionID: 456, BidderCode: "pubmatic-1"},
},
wantErr: false,
},
{
name: "Valid_request_ext_with_empty_alias",
args: args{
request: &openrtb2.BidRequest{
Ext: json.RawMessage(`{"prebid":{"aliases":{},"bidderparams":{"wrapper":{"profile":123,"version":456}}}}`),
},
},
expectedReqExt: extRequestAdServer{
Wrapper: &pubmaticWrapperExt{ProfileID: 123, VersionID: 456, BidderCode: "pubmatic"},
},
wantErr: false,
},
Expand Down
3 changes: 2 additions & 1 deletion adapters/pubmatic/pubmatictest/exemplary/banner.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,8 @@
"ext": {
"wrapper": {
"profile": 5123,
"version":1
"version":1,
"biddercode":"pubmatic"
},
"acat": ["drg","dlu","ssr"]
}
Expand Down
3 changes: 2 additions & 1 deletion adapters/pubmatic/pubmatictest/exemplary/native.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,8 @@
"ext": {
"wrapper": {
"profile": 5123,
"version": 1
"version": 1,
"biddercode":"pubmatic"
}
}
},
Expand Down
3 changes: 2 additions & 1 deletion adapters/pubmatic/pubmatictest/exemplary/video.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,8 @@
"ext": {
"wrapper": {
"profile": 5123,
"version":1
"version":1,
"biddercode":"pubmatic"
},
"acat": ["drg","dlu","ssr"]
}
Expand Down
3 changes: 2 additions & 1 deletion adapters/pubmatic/pubmatictest/supplemental/bid_ext_ibv_true.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,8 @@
"ext": {
"wrapper": {
"profile": 5123,
"version":1
"version":1,
"biddercode":"pubmatic"
},
"acat": ["drg","dlu","ssr"]
}
Expand Down
3 changes: 2 additions & 1 deletion adapters/pubmatic/pubmatictest/supplemental/extra-bid.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,8 @@
"ext": {
"wrapper": {
"profile": 5123,
"version":1
"version":1,
"biddercode":"pubmatic"
},
"acat": ["drg","dlu","ssr"],
"marketplace": {
Expand Down
3 changes: 2 additions & 1 deletion adapters/pubmatic/pubmatictest/supplemental/native_invalid_adm.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,8 @@
"ext": {
"wrapper": {
"profile": 5123,
"version": 1
"version": 1,
"biddercode":"pubmatic"
}
}
},
Expand Down
3 changes: 2 additions & 1 deletion adapters/pubmatic/pubmatictest/supplemental/nilReqExt.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,8 @@
"ext": {
"wrapper": {
"profile": 5123,
"version": 1
"version": 1,
"biddercode":"pubmatic"
}
}
},
Expand Down
3 changes: 2 additions & 1 deletion adapters/pubmatic/pubmatictest/supplemental/reqBidderParams.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,8 @@
"ext": {
"wrapper": {
"profile": 1234,
"version": 2
"version": 2,
"biddercode":"pubmatic"
}
}
},
Expand Down
176 changes: 176 additions & 0 deletions adapters/pubmatic/pubmatictest/supplemental/reqExtPrebidAliases.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,176 @@
{
"mockBidRequest": {
"id": "test-request-id",
"imp": [
{
"id": "test-imp-id",
"banner": {
"format": [
{
"w": 300,
"h": 250
}
]
},
"ext": {
"bidder": {
"adSlot": "AdTag_Div1@300x250",
"publisherId": " 999 ",
"keywords": [
{
"key": "pmZoneID",
"value": [
"Zone1",
"Zone2"
]
},
{
"key": "preference",
"value": [
"sports",
"movies"
]
}
],
"wrapper": {
"version": 1,
"profile": 5123
}
}
}
}
],
"device": {
"ua": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.132 Safari/537.36"
},
"ext": {
"prebid": {
"aliases": {
"pubmatic-alias": "pubmatic"
},
"bidderparams": {
"wrapper": {
"profile": 1234,
"version": 2
}
}
}
},
"site": {
"id": "siteID",
"publisher": {
"id": "1234"
}
}
},
"httpCalls": [
{
"expectedRequest": {
"uri": "https://hbopenbid.pubmatic.com/translator?source=prebid-server",
"body": {
"id": "test-request-id",
"imp": [
{
"id": "test-imp-id",
"tagid": "AdTag_Div1",
"banner": {
"format": [
{
"w": 300,
"h": 250
}
],
"h": 250,
"w": 300
},
"ext": {
"pmZoneId": "Zone1,Zone2",
"preference": "sports,movies"
}
}
],
"device": {
"ua": "Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.132 Safari/537.36"
},
"site": {
"id": "siteID",
"publisher": {
"id": "999"
}
},
"ext": {
"wrapper": {
"profile": 1234,
"version": 2,
"biddercode": "pubmatic-alias"
}
}
},
"impIDs": ["test-imp-id"]
},
"mockResponse": {
"status": 200,
"body": {
"id": "test-request-id",
"seatbid": [
{
"seat": "958",
"bid": [
{
"id": "7706636740145184841",
"impid": "test-imp-id",
"price": 0.500000,
"adid": "29681110",
"adm": "some-test-ad",
"adomain": [
"pubmatic.com"
],
"crid": "29681110",
"h": 250,
"w": 300,
"dealid": "test deal",
"mtype": 1,
"ext": {
"dspid": 6,
"deal_channel": 1
}
}
]
}
],
"bidid": "5778926625248726496",
"cur": "USD"
}
}
}
],
"expectedBidResponses": [
{
"currency": "USD",
"bids": [
{
"bid": {
"id": "7706636740145184841",
"impid": "test-imp-id",
"price": 0.5,
"adid": "29681110",
"adm": "some-test-ad",
"adomain": [
"pubmatic.com"
],
"crid": "29681110",
"w": 300,
"h": 250,
"dealid": "test deal",
"mtype": 1,
"ext": {
"dspid": 6,
"deal_channel": 1
}
},
"type": "banner"
}
]
}
]
}
9 changes: 8 additions & 1 deletion exchange/exchangetest/aliases.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,14 @@
}
}
}
]
],
"ext": {
"prebid": {
"aliases": {
"districtm": "appnexus"
}
}
}
}
},
"mockResponse": {
Expand Down
9 changes: 8 additions & 1 deletion exchange/exchangetest/bidadjustmentfactors.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,14 @@
}
}
}
]
],
"ext": {
"prebid": {
"aliases": {
"districtm": "appnexus"
}
}
}
},
"bidAdjustments": {
"appnexus": 2.5,
Expand Down
Loading
Loading