feature: Issue #17 - Registration Number Policies#40
Merged
PooriaT merged 10 commits intofeature/create-api-client-policy-modulefrom Feb 23, 2024
Conversation
nam-m
requested changes
Feb 15, 2024
analytics/policy/tests/unit/test_registration_number_policies.py
Outdated
Show resolved
Hide resolved
analytics/policy/tests/unit/test_registration_number_policies.py
Outdated
Show resolved
Hide resolved
analytics/policy/tests/unit/test_registration_number_policies.py
Outdated
Show resolved
Hide resolved
analytics/policy/tests/unit/test_registration_number_policies.py
Outdated
Show resolved
Hide resolved
umsu2
reviewed
Feb 15, 2024
analytics/policy/tests/unit/test_registration_number_policies.py
Outdated
Show resolved
Hide resolved
…-module' into feature/policy/mock_policies_for_registration_number_#17
nam-m
requested changes
Feb 23, 2024
Contributor
nam-m
left a comment
There was a problem hiding this comment.
Thanks for your update
2 changes I recommend are:
- Remove
total_countcheck in the policies - In the tests, you can set registration numbers one time outside(maybe parametrize too), and let all tests go through these
analytics/policy/tests/unit/test_registration_number_policies.py
Outdated
Show resolved
Hide resolved
analytics/policy/tests/unit/test_registration_number_policies.py
Outdated
Show resolved
Hide resolved
analytics/policy/tests/unit/test_registration_number_policies.py
Outdated
Show resolved
Hide resolved
nam-m
requested changes
Feb 23, 2024
nam-m
approved these changes
Feb 23, 2024
nam-m
approved these changes
Feb 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Issue Link: Mock policies for registration number #17
In this issue, a verification for the registration number is provided. First, the registration number has to be validated. Then, it should be checked whether it is available in Vancouver Open Data.
Type of Change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Checklist:
Before you submit your pull request, please make sure you have completed the following: