-
Notifications
You must be signed in to change notification settings - Fork 31
Add composer support. #16
base: master
Are you sure you want to change the base?
Conversation
…e need to be switched out in favour of "require" definitions.
|
@samwilson Thanks for the PR! I have started working on this recently, but I wanted to replace the vendor packages first. I don't think feel it's a good idea to merge this PR, because you have put it under your name (as a vendor name in Composer). @ivank what do you think? |
|
Here are my changes so far: https://github.com/hkdobrev/asset-merger/compare/composer |
|
I quite agree, it's not right at all the way I've got it. I just was hacking it together this morning because I wanted to get something working for another project... but yes, if @ivank is agreeable, it would be great to get this module Composer-ized. :-) |
…move a few third-party libraries. Conflicts: composer.json
|
Oh, and can drop the https://github.com/OpenBuildings/kohana-test-bootstrap requirement do you think, because core and all the modules now have composer.json files too? |
@samwilson What do you mean? They have |
|
No, you're quite right: I was thinking that the modules were already on packagist. Looks like they will be soon though! Which will be nice. :-) Forget my comment about the test-bootstrap, I was failing to consider Travis, and thought that it would be replaced by the kohana/unittest module only. :( I have modified the composer.json, and removed coffeescript, cssmin, and lessphp. Do we add repository entries for the other libraries, or leave them packaged here as they are? |
|
Oh, forget that. Of course they stay packaged here until they get composer.json files! :-) |
Vendor modules are still included however; these need to be switched out in favour of "require" definitions.
Also, I've just realised that the authors in here are those from my fork, so don't all apply. Does that matter? Can we get the other forks merged? Is anyone maintaining this project any more anyway? ;-)
Thanks for your consideration of this request.