-
Notifications
You must be signed in to change notification settings - Fork 8
chore: add REUSE v3.3 compliance #67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I don't think the triad line is required in addition to the OpenCHAMI line in each file based on my previous reading of our code guidelines. If you're sure we need it, we should add it elsewhere and update the copyright year to either 2026 or 2024-2026 |
|
I am actually not sure if we need it. I chose to err on the safe side and include it since that was the license before OpenCHAMI joined the LF. I'm happy to get rid of it if it's not required anywhere, just didn't want to get into trouble. 🙂 |
|
Capturing discussion from meeting:
|
Add SPDX identifiers and copyrights using an MIT license. See: https://reuse.software/spec-3.3/ Signed-off-by: Devon Bautista <17506592+synackd@users.noreply.github.com>
Signed-off-by: Devon Bautista <17506592+synackd@users.noreply.github.com>
Signed-off-by: Devon Bautista <17506592+synackd@users.noreply.github.com>
|
Made the following changes:
Does that work, @alexlovelltroy? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see anything referencing CC0. Do we need it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is referenced here:
ochami/.github/workflows/reuse.yaml
Line 2 in 3cfdaa2
| # SPDX-License-Identifier: CC0-1.0 |
That file was copied from here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding is that since the file was used from reuse.software and has a copyright/license, we must include the copyright/license license and thus the CC0 license to be compliant. Is that not the case?
Pull Request Template
Thank you for your contribution! Please ensure the following before submitting:
Checklist
make test(or equivalent) locally and all tests passgit commit -s) with my real name and email<filename>.licensesidecarLICENSES/directoryDescription
Add REUSE v3.3 compliance to the repo. This includes adding the necessary licenses, SPDX references, and CI checks that check for compliance.
The new MIT license from the Linux Foundation is the current license (2026), while the old Triad license is added for 2024 (when this project was created).
Type of Change
For more info, see Contributing Guidelines.