Skip to content

Conversation

@synackd
Copy link
Collaborator

@synackd synackd commented Jan 13, 2026

Pull Request Template

Thank you for your contribution! Please ensure the following before submitting:

Checklist

  • My code follows the style guidelines of this project
  • I have added/updated comments where needed
  • I have added tests that prove my fix is effective or my feature works
  • I have run make test (or equivalent) locally and all tests pass
  • DCO Sign-off: All commits are signed off (git commit -s) with my real name and email
  • REUSE Compliance:
    • Each new/modified source file has SPDX copyright and license headers
    • Any non-commentable files include a <filename>.license sidecar
    • All referenced licenses are present in the LICENSES/ directory

Description

Add REUSE v3.3 compliance to the repo. This includes adding the necessary licenses, SPDX references, and CI checks that check for compliance.

The new MIT license from the Linux Foundation is the current license (2026), while the old Triad license is added for 2024 (when this project was created).

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

For more info, see Contributing Guidelines.

@alexlovelltroy
Copy link
Member

I don't think the triad line is required in addition to the OpenCHAMI line in each file based on my previous reading of our code guidelines. If you're sure we need it, we should add it elsewhere and update the copyright year to either 2026 or 2024-2026

@synackd
Copy link
Collaborator Author

synackd commented Jan 13, 2026

I am actually not sure if we need it. I chose to err on the safe side and include it since that was the license before OpenCHAMI joined the LF. I'm happy to get rid of it if it's not required anywhere, just didn't want to get into trouble. 🙂

@alexlovelltroy
Copy link
Member

Capturing discussion from meeting:

  1. MIT license is the sole license for OpenCHAMI code.
  2. Participants may retain copyright over their code with multiple copyright lines at the top of each source file. There is no requirement that all files in the same repository have the same copyright lines.
  3. It is my understanding that the Triad contract statement is not required on OpenCHAMI contributions, but including it isn't problematic.

Add SPDX identifiers and copyrights using an MIT license.

See: https://reuse.software/spec-3.3/

Signed-off-by: Devon Bautista <17506592+synackd@users.noreply.github.com>
Signed-off-by: Devon Bautista <17506592+synackd@users.noreply.github.com>
Signed-off-by: Devon Bautista <17506592+synackd@users.noreply.github.com>
@synackd
Copy link
Collaborator Author

synackd commented Jan 13, 2026

Made the following changes:

  1. Got rid of the LICENSES/LicenseRef-Triad.txt license
  2. Changed Triad copyright from 2024 to 2024-2025
  3. Changed OpenCHAMI copyright from 2026 to 2025 (the year OpenCHAMI joined the HPSF)

Does that work, @alexlovelltroy?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything referencing CC0. Do we need it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is referenced here:

# SPDX-License-Identifier: CC0-1.0

That file was copied from here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that since the file was used from reuse.software and has a copyright/license, we must include the copyright/license license and thus the CC0 license to be compliant. Is that not the case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants