-
Notifications
You must be signed in to change notification settings - Fork 9
seantronsen/replace minio #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
seantronsen/replace minio #70
Conversation
|
Looks good from a glance. I want to give it a try in a bit for next week. |
synackd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Initial review before testing.
There seems to be a bug with the GitHub UI that prevents me from commenting on multiple lines under certain conditions so I've commented on one line for some of these.
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
…more info Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
7f86de9 to
7a57dcb
Compare
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
davidallendj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested this and was able to boot a node using Versity S3 instead of MinIO.
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
synackd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review for DNS port conflict warning.
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
|
All of the threads have been resolved, but I would like to test this again on both the cloud and VM setups before approving. Also, I'd like to get @davidallendj's blessing as well since he will be presenting the tutorial soon. |
synackd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran through the tutorial once more and figured we might as well update the kernel versions while we have actual output. Probably most of the comments are that. 🙂
I'm going to run it again after we present tomorrow on Thursday. When I ran through it before though, it looked good, but I'll look at the changes and see if there's anything that stands out. |
|
Cool. I ran through this today both on Jetstream2 and Libvirt VMs and, with my changes, everything worked. (There was one thing with the Kickstart stuff for the head node VM where some packages didn't get installed, but that's a problem for a different PR.) |
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Co-authored-by: Devon Bautista <17506592+synackd@users.noreply.github.com> Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Co-authored-by: Devon Bautista <17506592+synackd@users.noreply.github.com> update with rocky 9.7 - squash me Co-authored-by: Devon Bautista <17506592+synackd@users.noreply.github.com> update with rocky 9.7 - squash me Co-authored-by: Devon Bautista <17506592+synackd@users.noreply.github.com> update with rocky 9.7 - squash me Co-authored-by: Devon Bautista <17506592+synackd@users.noreply.github.com> update with rocky 9.7 - squash me Co-authored-by: Devon Bautista <17506592+synackd@users.noreply.github.com> update with rocky 9.7 - squash me Co-authored-by: Devon Bautista <17506592+synackd@users.noreply.github.com> Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Co-authored-by: Devon Bautista <17506592+synackd@users.noreply.github.com> Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
b8883bd to
932182b
Compare
Noted, everything should be all good to go now, but I'll double check it once more before I call it a night. |
|
Testing completed: Instructions for the There are some discrepancies in CLI output where sometimes rocky9.6 is referenced despite the recent efforts to update all such instances to 9.7. It's nothing that will affect the tutorial though. Still, I will take a moment to look for all such instances and make a quick swap since the effort to change all outputs to 9.7 is already underway. |
Signed-off-by: Sean Tronsen <sean.tronsen@gmail.com>
Complete as of: 1fca7f1 |
synackd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caught one of my own errors...
Signed-off-by: Devon Bautista <17506592+synackd@users.noreply.github.com>
22dc140 to
784ca84
Compare
synackd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving since all of my comments were addressed and I have tested this myself. Refraining from merging until @davidallendj reviews.
Pull Request Template
Thank you for your contribution! Please ensure the following before submitting:
Checklist
make test(or equivalent) locally and all tests passgit commit -s) with my real name and email<filename>.licensesidecarLICENSES/directoryDescription
This is a port of PR OpenCHAMI/tutorial-2025#12 which targeted: OpenCHAMI/tutorial-2025#11
Below is a modified variant of the description listed in the original PR.
The primary purpose of this PR is to switch the tutorial from
miniotoversitygwas the former is terminating support for open-source. To this end, the existing openchami quadlet forversitygwwas introduced. Some additional updates were introduced and are listed below:corednsCorefileto address port conflicts withdnsmasqandaardvarkawsCLI to addresss3cmdXML schema incompatibilities forsetaclType of Change
For more info, see Contributing Guidelines.