Pregenerate device-driver manifest files to speed up compilation#54
Merged
tullom merged 4 commits intoOpenDevicePartnership:mainfrom Feb 13, 2026
Merged
Conversation
7aa7adc to
e9ad361
Compare
e9ad361 to
62bf145
Compare
kurtjd
previously approved these changes
Feb 11, 2026
jerrysxie
previously approved these changes
Feb 12, 2026
Contributor
jerrysxie
left a comment
There was a problem hiding this comment.
Non-blocking, but will there be a follow-up PR to validate that these pre-generated files are valid through CI?
761cd1d to
353c2ae
Compare
353c2ae to
02494a2
Compare
02494a2 to
233832d
Compare
Contributor
Author
Done, CI will now generate the device-driver code and diff it with the checked in generated code. if theres a diff it fails CI. Also TIL that git will not check in capitalization changes in filenames unless you explicitly do a |
kurtjd
previously approved these changes
Feb 12, 2026
kurtjd
approved these changes
Feb 12, 2026
jerrysxie
approved these changes
Feb 12, 2026
thdesil
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't uprev version yet, as I have another nonbreaking change coming down the pipe.
Large file changes are just
device-drivergenerated files.Resolves #51