Skip to content

Pregenerate device-driver manifest files to speed up compilation#54

Merged
tullom merged 4 commits intoOpenDevicePartnership:mainfrom
tullom:pregenerate-device-driver
Feb 13, 2026
Merged

Pregenerate device-driver manifest files to speed up compilation#54
tullom merged 4 commits intoOpenDevicePartnership:mainfrom
tullom:pregenerate-device-driver

Conversation

@tullom
Copy link
Contributor

@tullom tullom commented Feb 11, 2026

Don't uprev version yet, as I have another nonbreaking change coming down the pipe.

Large file changes are just device-driver generated files.

Resolves #51

@tullom tullom self-assigned this Feb 11, 2026
@tullom tullom requested a review from a team as a code owner February 11, 2026 22:33
@tullom tullom requested review from seanbrns and thdesil February 11, 2026 22:33
@tullom tullom added the enhancement New feature or request label Feb 11, 2026
@tullom tullom force-pushed the pregenerate-device-driver branch from 7aa7adc to e9ad361 Compare February 11, 2026 23:08
kurtjd
kurtjd previously approved these changes Feb 11, 2026
jerrysxie
jerrysxie previously approved these changes Feb 12, 2026
Copy link
Contributor

@jerrysxie jerrysxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking, but will there be a follow-up PR to validate that these pre-generated files are valid through CI?

@tullom tullom dismissed stale reviews from jerrysxie and kurtjd via b96a921 February 12, 2026 15:54
@tullom tullom force-pushed the pregenerate-device-driver branch 11 times, most recently from 761cd1d to 353c2ae Compare February 12, 2026 17:06
@tullom tullom force-pushed the pregenerate-device-driver branch from 353c2ae to 02494a2 Compare February 12, 2026 17:10
@tullom tullom force-pushed the pregenerate-device-driver branch from 02494a2 to 233832d Compare February 12, 2026 17:11
@tullom
Copy link
Contributor Author

tullom commented Feb 12, 2026

Non-blocking, but will there be a follow-up PR to validate that these pre-generated files are valid through CI?

Done, CI will now generate the device-driver code and diff it with the checked in generated code. if theres a diff it fails CI.

Also TIL that git will not check in capitalization changes in filenames unless you explicitly do a git mv File.yaml file.yaml

@tullom tullom requested review from jerrysxie and kurtjd February 12, 2026 17:19
kurtjd
kurtjd previously approved these changes Feb 12, 2026
@tullom tullom merged commit 80416e8 into OpenDevicePartnership:main Feb 13, 2026
28 checks passed
@github-project-automation github-project-automation bot moved this from In review to Done in Embedded Controller Feb 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Autogenerate driver manifest file

4 participants