Allow changing driver config on the fly#55
Open
tullom wants to merge 1 commit intoOpenDevicePartnership:mainfrom
Open
Allow changing driver config on the fly#55tullom wants to merge 1 commit intoOpenDevicePartnership:mainfrom
tullom wants to merge 1 commit intoOpenDevicePartnership:mainfrom
Conversation
tullom
requested review from
RobertZ2011,
felipebalbi,
jerrysxie,
kurtjd,
seanbrns,
thdesil and
williampMSFT
tullom
force-pushed
the
dynamic-config
branch
2 times, most recently
from
99075fb to
0dcf687
Compare
RobertZ2011
previously approved these changes
Feb 17, 2026
src/versions/r1.rs
Outdated
| /// | ||
| /// Concurrency is guaranteed by the mutable borrow, ensuring the config cannot change | ||
| /// while a register transaction is in flight. | ||
| pub fn change_config(&mut self, config: Config) { |
Contributor
There was a problem hiding this comment.
nit: I think I'd favor either set_config or update_config. Any other opinions here?
- PEC, timeout time, and number of retries can now be changed without creating a new instance of the driver - Uprev to v0.8.1 - Remove deprecated `authors` field in Cargo.toml
tullom
force-pushed
the
dynamic-config
branch
from
0dcf687 to
6581bcc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
authorsfield in Cargo.toml