Skip to content

battery-service: Fix ACPI response #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kurtjd merged 1 commit into from
Feb 11, 2026
Merged

battery-service: Fix ACPI response #713

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions battery-service/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,18 +66,18 @@ impl Service {
}
Event::AcpiRequest(acpi_msg) => {
trace!("Battery service: ACPI cmd recvd");
match self.context.process_acpi_cmd(&acpi_msg).await {
Ok(response) => {
// TODO We should probably be responding to the requestor rather than just assuming the request came from the host
self.comms_send(
crate::EndpointID::External(embedded_services::comms::External::Host),
&response,
)
.await
.expect("comms_send is infallible")
}
Err(e) => error!("Battery service command failed: {:?}", e),
let response = self.context.process_acpi_cmd(&acpi_msg).await;
if let Err(e) = response {
error!("Battery service command failed: {:?}", e)
}

// TODO We should probably be responding to the requestor rather than just assuming the request came from the host
self.comms_send(
crate::EndpointID::External(embedded_services::comms::External::Host),
&response,
)
.await
.expect("comms_send is infallible")
}
}
}
Expand Down